Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_velocity_planner): use polling subscriber to efficiently get messages #7223

Merged
merged 4 commits into from
Jun 10, 2024

fix assign after return

6cbbbc0
Select commit
Loading
Failed to load commit list.
Merged

feat(motion_velocity_planner): use polling subscriber to efficiently get messages #7223

fix assign after return
6cbbbc0
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jun 6, 2024 in 57s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Complex Method node.cpp: MotionVelocityPlannerNode::is_data_ready

Annotations

Check notice on line 142 in planning/motion_velocity_planner/autoware_motion_velocity_planner_node/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Complex Method 

MotionVelocityPlannerNode::is_data_ready is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 174 in planning/motion_velocity_planner/autoware_motion_velocity_planner_node/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ New issue: Complex Method 

MotionVelocityPlannerNode::update_planner_data has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis