Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(radar_tracks_msgs_converter, simple_object_merger, radar_tracks_noise_filter)!: add package name prefix of autoware_ #8173

Merged

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jul 24, 2024

Description

This PR adds the autoware_ prefix to the package name.

  • radar_tracks_msgs_converter
  • simple_object_merger
  • radar_tracks_noise_filter

Changes are as following.

  1. Folder name (appears as file renaming)
  2. Package names in CMakeLists.txt, package.xml
  3. README.md
  4. Launch files $(find-pkg-share ...)
  5. .github/CODEOWNERS

This PR do not contains any logic change.

Related links

Part of: autowarefoundation/autoware#4569

Launcher update tier4/aip_launcher#267

How was this PR tested?

(radar_tracks_msgs_converter, radar_tracks_noise_filter)Tested in a local recompute environment and the TIER IV Cloud environment.

(simple_object_merger) A specific deploy that uses this package was used for local test.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…r_tracks_msgs_converter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…ct_merger

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…e_radar_tracks_noise_filter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jul 24, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.07%. Comparing base (4fa23be) to head (69b94a1).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8173      +/-   ##
==========================================
- Coverage   29.11%   29.07%   -0.05%     
==========================================
  Files        1607     1612       +5     
  Lines      118177   118482     +305     
  Branches    50851    50905      +54     
==========================================
+ Hits        34410    34446      +36     
- Misses      74528    74789     +261     
- Partials     9239     9247       +8     
Flag Coverage Δ *Carryforward flag
differential 2.76% <ø> (?)
total 29.11% <ø> (ø) Carriedforward from 4fa23be

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin merged commit bab6f4f into autowarefoundation:main Jul 25, 2024
41 of 43 checks passed
@technolojin technolojin deleted the refactor/prefix-radar-group3 branch July 26, 2024 02:19
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 26, 2024
…cks_noise_filter)!: add package name prefix of autoware_ (autowarefoundation#8173)

* refactor: rename radar_tracks_msgs_converter package to autoware_radar_tracks_msgs_converter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename simple_object_merger package to autoware_simple_object_merger

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename sensing/radar_tracks_noise_filter to sensing/autoware_radar_tracks_noise_filter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…cks_noise_filter)!: add package name prefix of autoware_ (autowarefoundation#8173)

* refactor: rename radar_tracks_msgs_converter package to autoware_radar_tracks_msgs_converter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename simple_object_merger package to autoware_simple_object_merger

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename sensing/radar_tracks_noise_filter to sensing/autoware_radar_tracks_noise_filter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants