-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(autoware_universe_utils): introduce managed transform buffer with implicitly defined listener type #9197
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9197 +/- ##
==========================================
- Coverage 26.39% 26.39% -0.01%
==========================================
Files 1389 1389
Lines 107757 107775 +18
Branches 41509 41517 +8
==========================================
+ Hits 28441 28445 +4
- Misses 76479 76495 +16
+ Partials 2837 2835 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This pull request has been automatically marked as stale because it has not had recent activity. |
6252fcd
to
00a18a9
Compare
Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
00a18a9
to
8232deb
Compare
@@ -33,15 +33,14 @@ Detail description of each ground segmentation algorithm is in the following lin | |||
|
|||
### Node Parameters | |||
|
|||
| Name | Type | Default Value | Description | | |||
| -------------------- | ------ | ------------- | ------------------------------------- | | |||
| `input_frame` | string | " " | input frame id | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really for this PR, but
" " does not evaluate as empty, so I think it goes against its apparent objective
if (!tf_input_frame_.empty() && cloud->header.frame_id != tf_input_frame_) { |
@badai-nguyen what do you think?
Description
See parent issue.
Related links
Parent Issue:
How was this PR tested?
To validate number of listeners during runtime, use
ros2 node list | grep impl -c
.Notes for reviewers
Interface changes
has_static_tf_only
parameter is not necessary anymore.getTransform
now has formgetTransform<typename T>
(geometry_msgs::msg::TransformStamped
,tf2::Transform
,Eigen::Matrix4f
).getTransform
returnsstd::optional
.Effects on system behavior
See parent issue.