-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(perception): move CUDA related packages to perception/cuda
directory
#9368
Conversation
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9368 +/- ##
==========================================
- Coverage 29.79% 29.60% -0.19%
==========================================
Files 1338 1385 +47
Lines 103300 104841 +1541
Branches 40232 40681 +449
==========================================
+ Hits 30779 31040 +261
- Misses 69537 70784 +1247
- Partials 2984 3017 +33
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youtalk
[must]
Please change the title of your PR to show that your PR has BREAKING CHANGE
.
e.g.
refactor(perception)!:
c.f.
https://github.com/autowarefoundation/autoware-documentation/blob/476ee2726920448824952e27432055299216b538/docs/contributing/pull-request-guidelines/index.md?plain=1#L135-L137
https://www.conventionalcommits.org/en/v1.0.0/
I will change this PR to PRs that move the packages one by one. |
Description
Currently, in the awf/autoware Dockerfile, sensing/perception packages that are built with CUDA libraries are explicitly listed and built as follows.
https://github.com/autowarefoundation/autoware/blob/main/docker/Dockerfile#L273-L284
However, this approach has poor maintainability if packages are added or renamed in the future. Therefore, in this PR, these CUDA-related packages will be moved to the
perception/cuda
directory.Related links
sensing/cuda
directory #9369sensing/cuda
andperception/cuda
directories autoware#5454How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.