Skip to content

fix(static_obstacle_avoidance): turn signal chattering

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Feb 28, 2025 in 36s

CodeScene PR Check

Quality Gate Passed

Code Health Improved (1 files improve in Code Health)

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

View Improvements
File Code Health Impact Categories Improved
scene.cpp 5.28 β†’ 5.30 Complex Method, Overall Code Complexity

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

βœ… Improving Code Health:

  • Overall Code Complexity scene.cpp πŸ”₯
  • Complex Method scene.cpp: StaticObstacleAvoidanceModule::getTurnSignal πŸ”₯

Annotations

Check notice on line 971 in planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/src/scene.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… Getting better: Complex Method

StaticObstacleAvoidanceModule::getTurnSignal decreases in cyclomatic complexity from 16 to 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/src/scene.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 5.77 to 5.74, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.