Skip to content

Commit

Permalink
no-prebuilt to devel-only
Browse files Browse the repository at this point in the history
  • Loading branch information
oguzkaganozt committed Jan 11, 2024
1 parent 31ba91e commit 37b8059
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
1 change: 0 additions & 1 deletion .github/workflows/docker-build-and-push-main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ jobs:
*.platform=linux/amd64
*.args.ROS_DISTRO=${{ env.rosdistro }}
*.args.BASE_IMAGE=${{ env[format('{0}', matrix.base_image_env)] }}
*.args.PREBUILT_BASE_IMAGE=${{ env.prebuilt_base_image }}
*.args.SETUP_ARGS=${{ matrix.setup-args }}
*.args.LIB_DIR=${{ matrix.lib_dir }}
tag-prefix: ${{ env.rosdistro }}-
Expand Down
4 changes: 2 additions & 2 deletions docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ To build without CUDA, use the `--no-cuda` option:
./docker/build.sh --no-cuda
```

To build only development image, use the `--no-prebuilt` option:
To build only development image, use the `--devel-only` option:

```bash
./docker/build.sh --no-prebuilt
./docker/build.sh --devel-only
```

To specify the platform, use the `--platform` option:
Expand Down
1 change: 1 addition & 0 deletions docker/autoware-openadk/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ ARG ROS_DISTRO
WORKDIR /autoware

# Build and change permission for runtime data conversion
COPY autoware.repos /autoware/
RUN --mount=type=ssh \
mkdir src \
&& vcs import src < autoware.repos \
Expand Down
14 changes: 7 additions & 7 deletions docker/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ print_help() {
echo " -h Display this help message"
echo " --no-cuda Disable CUDA support"
echo " --platform Specify the platform (default: current platform)"
echo " --no-prebuilt Build devel image only"
echo " --devel-only Build devel image only"
echo ""
echo "Note: The --platform option should be one of 'linux/amd64' or 'linux/arm64'."
}
Expand All @@ -33,8 +33,8 @@ parse_arguments() {
option_platform="$2"
shift
;;
--no-prebuilt)
option_no_prebuilt=true
--devel-only)
option_devel_only=true
;;
esac
shift
Expand All @@ -51,9 +51,9 @@ set_cuda_options() {
fi
}

# Set prebuilt options
set_prebuilt_options() {
if [ "$option_no_prebuilt" = "true" ]; then
# Set build options
set_build_options() {
if [ "$option_devel_only" = "true" ]; then
targets=("devel")
else
targets=()
Expand Down Expand Up @@ -123,7 +123,7 @@ build_images() {
# Main script execution
parse_arguments "$@"
set_cuda_options
set_prebuilt_options
set_build_options
set_platform
set_arch_lib_dir
load_env
Expand Down

0 comments on commit 37b8059

Please sign in to comment.