-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): remove rosdistro tag and add date as suffix #5216
Conversation
I ran the docker-build-and-push workflow. After finishing I will review this. |
Updated the PR and this is the new test workflow. Hopefully it will produce clean tags. |
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
d74a91a
to
c429822
Compare
@oguzkaganozt The tag list looks simpler and easier to read than before. Thank you for your contribution. |
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
This reverts commit a62bdd0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@oguzkaganozt We need to also update the autoware.universe
workflows for example https://github.com/autowarefoundation/autoware.universe/blob/main/.github/workflows/build-and-test-differential.yaml#L45, https://github.com/autowarefoundation/autoware-github-actions/blob/main/.github/workflows/test-composite-actions.yaml#L149 and the documentation after merging this.
Please help us.
Description
Remove rosdistro tag and add date as suffix in order to simplify docker tags
Tests performed
https://github.com/autowarefoundation/autoware/actions/runs/10832193807
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.