Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): remove rosdistro tag and add date as suffix #5216

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

oguzkaganozt
Copy link
Contributor

@oguzkaganozt oguzkaganozt commented Sep 11, 2024

Description

Remove rosdistro tag and add date as suffix in order to simplify docker tags

Tests performed

https://github.com/autowarefoundation/autoware/actions/runs/10832193807

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@oguzkaganozt oguzkaganozt self-assigned this Sep 11, 2024
@oguzkaganozt oguzkaganozt linked an issue Sep 11, 2024 that may be closed by this pull request
3 tasks
@oguzkaganozt oguzkaganozt changed the title remove rosdistro tag and add date as suffix fix(docker): remove rosdistro tag and add date as suffix Sep 11, 2024
@oguzkaganozt oguzkaganozt added the tag:run-health-check Run health-check label Sep 11, 2024
@youtalk
Copy link
Member

youtalk commented Sep 11, 2024

I ran the docker-build-and-push workflow.
https://github.com/autowarefoundation/autoware/actions/runs/10819893482

After finishing I will review this.
Thank you for your quick response.

@oguzkaganozt
Copy link
Contributor Author

oguzkaganozt commented Sep 12, 2024

Updated the PR and this is the new test workflow. Hopefully it will produce clean tags.

@oguzkaganozt oguzkaganozt added the component:openadkit Issues or Features related to Open AD Kit label Sep 12, 2024
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
@oguzkaganozt oguzkaganozt force-pushed the 5215-simplify-docker-image-tags branch from d74a91a to c429822 Compare September 12, 2024 13:47
@oguzkaganozt
Copy link
Contributor Author

@youtalk @mitsudome-r @xmfcx

Here are the latest state of docker containers:
Ekran görüntüsü 2024-09-12 181456

@oguzkaganozt oguzkaganozt enabled auto-merge (squash) September 12, 2024 15:16
@youtalk
Copy link
Member

youtalk commented Sep 13, 2024

@oguzkaganozt The tag list looks simpler and easier to read than before. Thank you for your contribution.

Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
This reverts commit a62bdd0.
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oguzkaganozt oguzkaganozt merged commit 9fbc35e into main Sep 17, 2024
15 checks passed
@oguzkaganozt oguzkaganozt deleted the 5215-simplify-docker-image-tags branch September 17, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Simplify docker image tags
2 participants