Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_lidar_transfusion): updated transfusion models #5318

Merged

Conversation

SamratThapa120
Copy link
Contributor

Description

This PR updates the transfusion models. The updated models have fixed names of the IO tensors, and produce an interpretable cls_score (TIER IV Internal Link).
Merge and review together with: autowarefoundation/autoware.universe#9057

It is recommended to re-download the transfusion model artifacts and update the transfusion package after the above universe PR, to get reliable more accurate predictions with transfusion.

Signed-off-by: Samrat Thapa <samratthapa120@gmail.com>
Copy link
Contributor

@amadeuszsz amadeuszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please, merge this PR with node fix PR at the same time.
FYI I'm not maintainer of this repository, I added back original reviewers 😄

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI problems will be solved by #5320.

Please check the Autoware Evaluator pass using this and autowarefoundation/autoware.universe#9057.

@youtalk youtalk enabled auto-merge (squash) October 10, 2024 02:41
@youtalk
Copy link
Member

youtalk commented Oct 10, 2024

I've merged the latest main branch and set auto-merge.

@SamratThapa120
Copy link
Contributor Author

SamratThapa120 commented Oct 10, 2024

@youtalk Thank you for quick response

@youtalk youtalk added the tag:run-health-check Run health-check label Oct 10, 2024
@SamratThapa120
Copy link
Contributor Author

SamratThapa120 commented Oct 10, 2024

@youtalk
Warning: Unknown word (semseg)

- name: Download tensorrt_yolox/semseg_color_map.csv

This warning is not caused by changes from this PR, it predates this PR.

And, the unknown word semseg is included in a filename, so I am not sure if it can be changed at all.

@youtalk
Copy link
Member

youtalk commented Oct 10, 2024

@SamratThapa120 I'm sorry but it's not a problem.

@amadeuszsz
Copy link
Contributor

@SamratThapa120

so I am not sure if it can be changed at all.

If you want to update our dictionary, you can refer to workflow. I just triggered workflow to suppress this warning caused by one of previous PRs.

@youtalk youtalk merged commit 2669af5 into autowarefoundation:main Oct 10, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants