Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Plan for autoware_path_generator #236

Open
5 of 14 tasks
sasakisasaki opened this issue Mar 4, 2025 · 1 comment
Open
5 of 14 tasks

Refactoring Plan for autoware_path_generator #236

sasakisasaki opened this issue Mar 4, 2025 · 1 comment
Assignees
@sasakisasaki
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:improvement Proposed enhancement

Comments

@sasakisasaki
Copy link
Contributor

sasakisasaki commented Mar 4, 2025 •
edited
Loading

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

I'm working on this PR. But I need to do continuous refactoring for the added code. I'm going to do refactoring step-by-step as follows. Let me register this issue not to forget the refactoring plan. Any your idea for the refactoring or comments are highly appreciated. Thank you!

  • Provide smooth path feature
  • Polish up coding style
    • Comment is understandable
    • Simplified
    • Variable name is appropriate
  • Add unit tests
    • Add one test case
      • For smooth goal connection, do not forget to do this
    • Add more tests so the coverage rate becomes 25%
    • Add more tests so the coverage rate becomes 45%
  • Utilize autoware_trajectory

Purpose

Refactoring for autoware_path_generator

Possible approaches

As wrote in the "Description"

Definition of done

Unit tests are added for this PR
@sasakisasaki sasakisasaki mentioned this issue Mar 4, 2025
Merged
@sasakisasaki sasakisasaki self-assigned this Mar 5, 2025
@sasakisasaki sasakisasaki added type:improvement Proposed enhancement component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Mar 5, 2025
@sasakisasaki
Copy link
Contributor Author

sasakisasaki commented Mar 19, 2025 •
edited
Loading

@kosuke55 As we talked in the TIER IV office, I added "Utilize autoware_trajectory" in the PR description 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sasakisasaki sasakisasaki

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:improvement Proposed enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sasakisasaki