Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the code quality and poor document of autoware_trajectory package #296

Open
3 tasks done
soblin opened this issue Mar 24, 2025 · 0 comments
Open
3 tasks done
Assignees

Comments

@soblin
Copy link
Contributor

soblin commented Mar 24, 2025

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

As described in the Purpose section, this package needs to be improved to align with core quality.

Also usage of raw Path message types like PathWithLaneId have caused a lot of bugs, so this class will cover all Path related feature so that it can replace motion_utils package.

Purpose

Current documentation of autoware_trajectory does not contain rich information like this page.

https://autowarefoundation.github.io/autoware_core/main/common/autoware_lanelet2_utils/

The series of PRs aims to enrich the documentation so that the developers can understand the geometric picture of complicated Path related algorithms, and similar functions are not reproduced across Autoware.

Possible approaches

Here are part of the duplicate function/logic related to Path manipulation.

concatenate trajectory

filter lane_ids

assign new lane_ids

generate new Path from Lanelet centerline

find the position which is specific meters away from a given position

check if ego is over a specific position

concatenate footprint polygons along path

trim a part of path

Definition of done

This task continues until motion_utils package gets almot unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant