Skip to content

feat(autoware_node): remove the lifecycle dependency #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Feb 13, 2025

Description

Parent Issue

Due to requirements of having to overload a lot of functions and maintaining Lifecycle states, we've decided to not build upon Lifecycle nodes for now. And keep the node structure simple in terms of states. It'd be very hard to test all those states so let's start simple.

In the future, in case we come up with a way to manage this complexity, it can be re-added.

Related links

How was this PR tested?

The node is too simple now, just build and test.

colcon test --event-handlers console_cohesion+ --packages-select autoware_node autoware_test_node

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx requested a review from a team as a code owner February 13, 2025 07:42
Copy link

github-actions bot commented Feb 13, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx self-assigned this Feb 13, 2025
@xmfcx xmfcx requested review from youtalk and mitsudome-r February 13, 2025 07:42
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 13, 2025
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.48%. Comparing base (4cb18f5) to head (0377b60).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...ommon/autoware_node/test/test_an_init_shutdown.cpp 66.66% 0 Missing and 5 partials ⚠️
...ommon/autoware_node/include/autoware/node/node.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   78.75%   79.48%   +0.73%     
==========================================
  Files          11       11              
  Lines         193      195       +2     
  Branches       73       73              
==========================================
+ Hits          152      155       +3     
+ Misses         11       10       -1     
  Partials       30       30              
Flag Coverage Δ *Carryforward flag
differential 60.00% <64.70%> (?)
total 80.89% <ø> (+2.14%) ⬆️ Carriedforward from 4cb18f5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r merged commit 5daa2f8 into main Feb 13, 2025
25 of 26 checks passed
@mitsudome-r mitsudome-r deleted the feat/autoware-node-no-lifecycle branch February 13, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants