Skip to content

ci(update-codeowners-from-packages): add build label #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Feb 21, 2025

Description

When this workflow tenerates a PR, we need to add the label manually to make it pass the CI.

This PR automates that.

How was this PR tested?

I will test with manual dispatch on the sync-files change to see if sd command works as expected.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx self-assigned this Feb 21, 2025
Copy link

github-actions bot commented Feb 21, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx
Copy link
Contributor Author

xmfcx commented Feb 21, 2025

image

I will include it in this PR.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx marked this pull request as ready for review February 21, 2025 11:42
@xmfcx xmfcx requested a review from a team as a code owner February 21, 2025 11:42
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the bots don’t commit frequently, I think it’s a good fix. Let’s merge it for now, and if any issues arise, we can reconsider then.

@xmfcx
Copy link
Contributor Author

xmfcx commented Feb 21, 2025

Thanks, this workflow runs once a day. And if there are no code owner changes, it doesn't create a PR.

So it shouldn't cause a problem on that end.

@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 21, 2025
@xmfcx
Copy link
Contributor Author

xmfcx commented Feb 21, 2025

Also the build-and-test differential job checks if any package is modified. And if no package is modified, it skips the checks.

Since this workflow only modifies the .github folder, the check will always be empty.

Maybe we can move this check outside the job itself to make it skip it earlier. Because right now, it will wait for pulling the image and waste time.

@xmfcx xmfcx merged commit a8c7334 into main Feb 21, 2025
27 of 28 checks passed
@xmfcx xmfcx deleted the ci/auto-add-label branch February 21, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants