-
Notifications
You must be signed in to change notification settings - Fork 71
ci(update-codeowners-from-packages): add build label #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
I will include it in this PR. |
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the bots don’t commit frequently, I think it’s a good fix. Let’s merge it for now, and if any issues arise, we can reconsider then.
Thanks, this workflow runs once a day. And if there are no code owner changes, it doesn't create a PR. So it shouldn't cause a problem on that end. |
Also the build-and-test differential job checks if any package is modified. And if no package is modified, it skips the checks. Since this workflow only modifies the .github folder, the check will always be empty. Maybe we can move this check outside the job itself to make it skip it earlier. Because right now, it will wait for pulling the image and waste time. |
Description
When this workflow tenerates a PR, we need to add the label manually to make it pass the CI.
This PR automates that.
How was this PR tested?
I will test with manual dispatch on the sync-files change to see if
sd
command works as expected.Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.