-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: autoware_motion_velocity_planner and autoware_motion_velocity_planner_common to core #242
Conversation
Signed-off-by: suchang <chang.su@autocore.ai>
Signed-off-by: suchang <chang.su@autocore.ai>
Signed-off-by: suchang <chang.su@autocore.ai>
…ithub.com/autowarefoundation/autoware.core into autoware_behavior_velocity_planner_common
Signed-off-by: suchang <chang.su@autocore.ai>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: suchang <chang.su@autocore.ai>
…owarefoundation/autoware.core into motion_velocity_planner_node
Signed-off-by: suchang <chang.su@autocore.ai>
Signed-off-by: suchang <chang.su@autocore.ai>
Signed-off-by: suchang <chang.su@autocore.ai>
Signed-off-by: suchang <chang.su@autocore.ai>
Signed-off-by: suchang <chang.su@autocore.ai>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
ab7b68a
to
f4c21ce
Compare
I will review this first.
|
…nner_common' into motion_velocity_planner_node
To unify the package structure with #230, I will make a minimal change by removing only the |
Got it ,kondo san 心刚 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed autoware_motion_velocity_planner_node
to autoware_motion_velocity_planner
and fix bugs. Then LGTM
Note that the merge branch is autoware_behavior_velocity_planner_common not main.
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
…velocity_planner_node, autoware_motion_velocity_planner_node, resolve build issue: v0.6 Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>
Kondo san @youtalk I look into the build error in #242 (comment) and fix it by ad29bb3 I notice that you do it also in 19b7150 My fix is based on you while remove more code which is not necessary for this phase porting, including:
i will assign @NorahXiong to add more test cases after we merge motion_velocity related packages to core Thanks again for your review 心刚 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
- Coverage 78.75% 0.00% -78.76%
==========================================
Files 11 101 +90
Lines 193 7076 +6883
Branches 73 1350 +1277
==========================================
- Hits 152 0 -152
- Misses 11 7076 +7065
+ Partials 30 0 -30
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@liuXinGangChina @NorahXiong @storrrrrrrrm Thank you for your patience and support. @mitsudome-r and I really wanted to finish merging all the current PRs by the end of today, so I went ahead and made the changes directly. |
Now CIs are all green. |
Kondo san @youtalk Thanks for your help and help from mits san,I believe we share the same goal “finish merging all the current PRs by the end of today” since it is also our duty and responsibility to the community I will take care of every pr that we created through the whole review process 心刚 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all build dependency has been meet for this pr
Next step
- merge this pr
- we should merge behavier_velocity_planner pr and pr in pairs
- then merge obj_stop plugin pr and pr in pairs
The dependent PR #230 was merged and this PR is not a porting. I enable auto-merge it. |
Description
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
ci of this pr would pass after autoware_motion_velocity_planner_common ported #307
Interface changes
None.
Effects on system behavior
None.