Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(osqp_interface): core changes for additional failure logging #281

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

PanConChicharron
Copy link
Contributor

@PanConChicharron PanConChicharron commented Mar 17, 2025

Description

Core changes for autowarefoundation/autoware_universe#10276

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Mar 17, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@PanConChicharron PanConChicharron marked this pull request as ready for review March 17, 2025 08:59
@PanConChicharron PanConChicharron requested a review from a team as a code owner March 17, 2025 08:59
@PanConChicharron PanConChicharron added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 17, 2025
@PanConChicharron PanConChicharron changed the title fix feat(obstacle_avoidance_planner): core changes fir additional failure logging Mar 17, 2025
PanConChicharron and others added 2 commits March 17, 2025 18:02
Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.67%. Comparing base (4cb18f5) to head (20b8777).
Report is 97 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   78.75%   82.67%   +3.92%     
==========================================
  Files          11        3       -8     
  Lines         193      254      +61     
  Branches       73      105      +32     
==========================================
+ Hits          152      210      +58     
- Misses         11       19       +8     
+ Partials       30       25       -5     
Flag Coverage Δ
differential ∅ <100.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source codes look good. Please fix the PR title typo fir. I think for would be correct.

@maxime-clem maxime-clem changed the title feat(obstacle_avoidance_planner): core changes fir additional failure logging feat(obstacle_avoidance_planner): core changes for additional failure logging Mar 18, 2025
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please don't merge the PR now because there are other packages in autoware.universe which may depend on this package.
If you merge this PR now, the autoware.universe cannot be built.

@takayuki5168 takayuki5168 changed the title feat(obstacle_avoidance_planner): core changes for additional failure logging feat(osqp_interface): core changes for additional failure logging Mar 18, 2025
@PanConChicharron PanConChicharron merged commit fcf9ab1 into main Mar 19, 2025
28 checks passed
@PanConChicharron PanConChicharron deleted the arjun.ram/RT0-33698 branch March 19, 2025 00:54
@xmfcx
Copy link
Contributor

xmfcx commented Mar 19, 2025

And, autoware universe cannot be built now.

@xmfcx
Copy link
Contributor

xmfcx commented Mar 19, 2025

@PanConChicharron Now autoware_tools doesn't compile too.

https://github.com/autowarefoundation/autoware_tools/blob/345a2bc05b4c259f80af0416bd2b5d39252bba43/planning/autoware_static_centerline_generator/src/centerline_source/optimization_trajectory_based_centerline.cpp#L166-L171

You should update these parts as well. Maybe more, please update soon 🙏

You can run vcs import src < tools-nightly.repos in the root autoware folder to pull the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants