-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(osqp_interface): core changes for additional failure logging #281
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
28c7ce0
to
8c266a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 78.75% 82.67% +3.92%
==========================================
Files 11 3 -8
Lines 193 254 +61
Branches 73 105 +32
==========================================
+ Hits 152 210 +58
- Misses 11 19 +8
+ Partials 30 25 -5
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source codes look good. Please fix the PR title typo fir
. I think for
would be correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please don't merge the PR now because there are other packages in autoware.universe which may depend on this package.
If you merge this PR now, the autoware.universe cannot be built.
And, autoware universe cannot be built now.
|
@PanConChicharron Now autoware_tools doesn't compile too. You should update these parts as well. Maybe more, please update soon 🙏 You can run |
Description
Core changes for autowarefoundation/autoware_universe#10276
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.