Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_velocity_smoother): port the package from Autoware Universe #299

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Mar 24, 2025

Description

This ports autoware_velocity_smoother package from Autoware Universe to Core as this is used by the behavior_velocity_planner_common.
It also resets the version and changelog of the package.

This must be merged with autowarefoundation/autoware_universe#10331

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Copy link

github-actions bot commented Mar 24, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is porting PR, I made minimum feedbacks.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 11.20419% with 1696 lines in your changes missing coverage. Please review.

Project coverage is 6.47%. Comparing base (4cb18f5) to head (389800f).
Report is 107 commits behind head on main.

Files with missing lines Patch % Lines
planning/autoware_velocity_smoother/src/node.cpp 24.87% 436 Missing and 5 partials ⚠️
..._smoother/analytical_jerk_constrained_smoother.cpp 0.00% 293 Missing ⚠️
...y_smoother/src/smoother/jerk_filtered_smoother.cpp 6.55% 214 Missing ⚠️
...k_constrained_smoother/velocity_planning_utils.cpp 0.00% 191 Missing ⚠️
...utoware_velocity_smoother/src/trajectory_utils.cpp 9.03% 140 Missing and 1 partial ⚠️
...moother/src/smoother/linf_pseudo_jerk_smoother.cpp 0.00% 118 Missing ⚠️
..._smoother/src/smoother/l2_pseudo_jerk_smoother.cpp 0.00% 111 Missing ⚠️
...e_velocity_smoother/src/smoother/smoother_base.cpp 27.20% 99 Missing ⚠️
...anning/autoware_velocity_smoother/src/resample.cpp 0.00% 87 Missing ⚠️
...oware/velocity_smoother/smoother/smoother_base.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #299       +/-   ##
==========================================
- Coverage   78.75%   6.47%   -72.29%     
==========================================
  Files          11      65       +54     
  Lines         193    4853     +4660     
  Branches       73    1514     +1441     
==========================================
+ Hits          152     314      +162     
- Misses         11    4527     +4516     
+ Partials       30      12       -18     
Flag Coverage Δ
differential 6.47% <11.20%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mitsudome-r mitsudome-r merged commit 4c6d043 into autowarefoundation:main Mar 25, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants