Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_stop_filter): port autoware_stop_filter from Autoware Universe #300

Merged

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Mar 25, 2025

Description

This ports autoware_stop_filter from Autoware Universe to Core
The package is a copy from Autoware Universe expect for the following modification:

  • reset version to 0.0.0 in package.xml
  • remove CHANGELOG.rst

This must be merged with: autowarefoundation/autoware_universe#10336

Related links

Parent Issue:

How was this PR tested?

I built the autoware locally and run rosbag simulation tutorial.
I confirmed that the node launches correctly with ros2 node info /localization/pose_twist_fusion_filter/stop_filter

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Mar 25, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r requested review from a team and Motsu-san March 25, 2025 02:33
@mitsudome-r mitsudome-r force-pushed the port-autoware_stop_filter branch from c40894f to 5bdf1ca Compare March 25, 2025 02:37
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I made a small feedback.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (4cb18f5) to head (48aba83).
Report is 110 commits behind head on main.

Files with missing lines Patch % Lines
...alization/autoware_stop_filter/src/stop_filter.cpp 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #300       +/-   ##
==========================================
- Coverage   78.75%   0.00%   -78.76%     
==========================================
  Files          11       1       -10     
  Lines         193      22      -171     
  Branches       73       0       -73     
==========================================
- Hits          152       0      -152     
- Misses         11      22       +11     
+ Partials       30       0       -30     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@youtalk youtalk requested review from YamatoAndo and xmfcx March 26, 2025 05:57
@YamatoAndo YamatoAndo added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Mar 26, 2025
…niverse

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r mitsudome-r force-pushed the port-autoware_stop_filter branch from c6c18db to 48aba83 Compare March 26, 2025 06:41
@mitsudome-r mitsudome-r merged commit 0de9080 into autowarefoundation:main Mar 26, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants