-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_stop_filter): port autoware_stop_filter from Autoware Universe #300
feat(autoware_stop_filter): port autoware_stop_filter from Autoware Universe #300
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
c40894f
to
5bdf1ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I made a small feedback.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
- Coverage 78.75% 0.00% -78.76%
==========================================
Files 11 1 -10
Lines 193 22 -171
Branches 73 0 -73
==========================================
- Hits 152 0 -152
- Misses 11 22 +11
+ Partials 30 0 -30
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…niverse Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
c6c18db
to
48aba83
Compare
Description
This ports autoware_stop_filter from Autoware Universe to Core
The package is a copy from Autoware Universe expect for the following modification:
This must be merged with: autowarefoundation/autoware_universe#10336
Related links
Parent Issue:
How was this PR tested?
I built the autoware locally and run rosbag simulation tutorial.
I confirmed that the node launches correctly with
ros2 node info /localization/pose_twist_fusion_filter/stop_filter
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.