-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_twist2accel): port autoware_twist2accel from Autoware Universe #302
feat(autoware_twist2accel): port autoware_twist2accel from Autoware Universe #302
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…niverse Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
c77a762
to
a9438ff
Compare
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to add at least one unit test, but since it's a porting PR, LGTM
I will made a separate PR to do it later.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
- Coverage 78.75% 0.00% -78.76%
==========================================
Files 11 6 -5
Lines 193 197 +4
Branches 73 23 -50
==========================================
- Hits 152 0 -152
- Misses 11 197 +186
+ Partials 30 0 -30
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
e2ff9e3
to
809cb3f
Compare
Description
This ports autoware_twist2accel from Autoware Universe to Core.
The package is a copy from Autoware Universe expect for the following modification:
This must be merged with: autowarefoundation/autoware_universe#10338
Related links
Parent Issue:
How was this PR tested?
Tested with the local build.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.