Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_twist2accel): port autoware_twist2accel from Autoware Universe #302

Merged

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Mar 25, 2025

Description

This ports autoware_twist2accel from Autoware Universe to Core.

The package is a copy from Autoware Universe expect for the following modification:

  • reset version to 0.0.0 in package.xml
  • remove CHANGELOG.rst

This must be merged with: autowarefoundation/autoware_universe#10338

Related links

Parent Issue:

How was this PR tested?

Tested with the local build.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Mar 25, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

…niverse

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r mitsudome-r force-pushed the port-autoware_twist2accel branch from c77a762 to a9438ff Compare March 25, 2025 05:37
@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 25, 2025
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r mitsudome-r marked this pull request as ready for review March 25, 2025 05:40
@youtalk youtalk requested a review from a team March 25, 2025 05:41
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to add at least one unit test, but since it's a porting PR, LGTM
I will made a separate PR to do it later.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (4cb18f5) to head (428f7fd).
Report is 111 commits behind head on main.

Files with missing lines Patch % Lines
...alization/autoware_twist2accel/src/twist2accel.cpp 0.00% 49 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #302       +/-   ##
==========================================
- Coverage   78.75%   0.00%   -78.76%     
==========================================
  Files          11       6        -5     
  Lines         193     197        +4     
  Branches       73      23       -50     
==========================================
- Hits          152       0      -152     
- Misses         11     197      +186     
+ Partials       30       0       -30     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r mitsudome-r force-pushed the port-autoware_twist2accel branch from e2ff9e3 to 809cb3f Compare March 25, 2025 08:19
@YamatoAndo YamatoAndo added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Mar 26, 2025
@mitsudome-r mitsudome-r merged commit 61d0716 into autowarefoundation:main Mar 26, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants