Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_velocity_smoother): porting to core repo #305

Closed
wants to merge 1 commit into from

Conversation

liuXinGangChina
Copy link
Contributor

@liuXinGangChina liuXinGangChina commented Mar 25, 2025

Description

porting autoware_velocity_smoother from universe to core

what i have done:

  1. simply move the code from universe to core without modification
  2. remove changelog.rst
  3. restart version in packages.xml from 0.0.0

Related links

Parent Issue:

How was this PR tested?

  1. colcon build with entire autoware packages
  2. p-sim a-to-b task

Notes for reviewers

Must merge with pr in universes repo -- autowarefoundation/autoware_universe#10340

Interface changes

None.

Effects on system behavior

None.

…other, add to core repo : v0.0

Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>
@liuXinGangChina liuXinGangChina added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:moving Temporary label to represent packages that are specifically moving from Universe to Core. labels Mar 25, 2025
@liuXinGangChina liuXinGangChina self-assigned this Mar 25, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 11.20419% with 1696 lines in your changes missing coverage. Please review.

Project coverage is 6.47%. Comparing base (4cb18f5) to head (1d6b291).
Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
planning/autoware_velocity_smoother/src/node.cpp 24.87% 436 Missing and 5 partials ⚠️
..._smoother/analytical_jerk_constrained_smoother.cpp 0.00% 293 Missing ⚠️
...y_smoother/src/smoother/jerk_filtered_smoother.cpp 6.55% 214 Missing ⚠️
...k_constrained_smoother/velocity_planning_utils.cpp 0.00% 191 Missing ⚠️
...utoware_velocity_smoother/src/trajectory_utils.cpp 9.03% 140 Missing and 1 partial ⚠️
...moother/src/smoother/linf_pseudo_jerk_smoother.cpp 0.00% 118 Missing ⚠️
..._smoother/src/smoother/l2_pseudo_jerk_smoother.cpp 0.00% 111 Missing ⚠️
...e_velocity_smoother/src/smoother/smoother_base.cpp 27.20% 99 Missing ⚠️
...anning/autoware_velocity_smoother/src/resample.cpp 0.00% 87 Missing ⚠️
...oware/velocity_smoother/smoother/smoother_base.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #305       +/-   ##
==========================================
- Coverage   78.75%   6.47%   -72.29%     
==========================================
  Files          11      65       +54     
  Lines         193    4853     +4660     
  Branches       73    1514     +1441     
==========================================
+ Hits          152     314      +162     
- Misses         11    4527     +4516     
+ Partials       30      12       -18     
Flag Coverage Δ
differential 6.47% <11.20%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mitsudome-r
Copy link
Member

@liuXinGangChina I actually created the same PR in #299 before I noticed your PR.

@liuXinGangChina
Copy link
Contributor Author

@liuXinGangChina I actually created the same PR in #299 before I noticed your PR.

hi mits san

Sorry not notice your pr, also close pr at universe respect to this one -- autowarefoundation/autoware_universe#10340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:moving Temporary label to represent packages that are specifically moving from Universe to Core.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants