Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoware_motion_velocity_planner_common): port to core repo #307

Closed
wants to merge 2 commits into from
Closed

feat(autoware_motion_velocity_planner_common): port to core repo #307

wants to merge 2 commits into from

Conversation

liuXinGangChina
Copy link
Contributor

@liuXinGangChina liuXinGangChina commented Mar 25, 2025 •
edited
Loading

Description

porting autoware_motion_velocity_planner_common from universe to core

what i have done:

  1. simply move the code from universe to core without modification
  2. remove changelog.rst
  3. restart version in packages.xml from 0.0.0
  4. add missing readme

Related links

Parent Issue:

  • Link

How was this PR tested?

  1. colcon build with entire autoware

Notes for reviewers

Must merge with after pr

  1. feat(autoware_velocity_smoother): port the package from Autoware Universe #299 -- autoware_velocity_smoother
  2. feat: port autoware_behavior_velocity_planner from autoware.universe to autoware.core #230 -- autoware_behavior_velocity_planner_common

Interface changes

None.

Effects on system behavior

None.

@liuXinGangChina liuXinGangChina added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:moving Temporary label to represent packages that are specifically moving from Universe to Core. labels Mar 25, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@liuXinGangChina liuXinGangChina force-pushed the autoware_motion_velocity_planner_common_universe_porting branch 2 times, most recently from c01e465 to 62727b0 Compare March 25, 2025 08:43
@youtalk youtalk requested a review from a team March 25, 2025 08:49
This was referenced Mar 25, 2025
Merged
Merged
@storrrrrrrrm storrrrrrrrm mentioned this pull request Mar 26, 2025
Merged
liuXinGangChina and others added 2 commits March 26, 2025 16:16
@liuXinGangChina
feat(autoware_motion_velocity_planner_common): porting autoware_motio…
ecd8195 
…n_velocity_planner_common, autoware_motion_velocity_planner_common, port to core repo: v0.0

Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>
@pre-commit-ci @liuXinGangChina
style(pre-commit): autofix
888b664
@liuXinGangChina liuXinGangChina force-pushed the autoware_motion_velocity_planner_common_universe_porting branch from 2dd7480 to 888b664 Compare March 26, 2025 08:16
@youtalk
Copy link
Member

youtalk commented Mar 26, 2025

It depends on #230.

@youtalk
Copy link
Member

youtalk commented Mar 27, 2025

Sorry but we need to merge this PR to #242 and close this PR instead. #242 (comment)

@youtalk youtalk closed this Mar 27, 2025
@youtalk youtalk deleted the autoware_motion_velocity_planner_common_universe_porting branch March 27, 2025 03:09
@youtalk youtalk restored the autoware_motion_velocity_planner_common_universe_porting branch March 27, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@maxime-clem maxime-clem maxime-clem approved these changes

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:moving Temporary label to represent packages that are specifically moving from Universe to Core.
Projects
Autoware Core Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liuXinGangChina @youtalk @takayuki5168 @maxime-clem