Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_motion_velocity_obstacle_stop_module): port to core repo #310

Merged

Conversation

liuXinGangChina
Copy link
Contributor

@liuXinGangChina liuXinGangChina commented Mar 25, 2025

Description

porting autoware_motion_velocity_obstacle_stop_module from universe to core

what i have done:

  1. simply move the code from universe to core without modification
  2. remove changelog.rst
  3. restart version in packages.xml from 0.0.0
  4. refactor readme according to porting guide
  5. replace dependency to "tier4_metric_msgs" with "autoware_internal_metric_msgs", i double check that this modification has no system level Influence since the topic xxx/stop/metrics use this message output to no nodes within autoware. It is just for autware user to monitor this plugin.

Related links

Parent Issue:

  • Link

How was this PR tested?

  1. colcon build with entire Autoware

Notes for reviewers

Must merge after pr -- #230

Must merge with pr under universe repo -- autowarefoundation/autoware_universe#10348

Interface changes

None.

Effects on system behavior

None.

@liuXinGangChina liuXinGangChina added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:moving Temporary label to represent packages that are specifically moving from Universe to Core. labels Mar 25, 2025
@liuXinGangChina liuXinGangChina self-assigned this Mar 25, 2025
Copy link

github-actions bot commented Mar 25, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@liuXinGangChina liuXinGangChina moved this from Todo to In Progress in Autoware Core Porting Mar 26, 2025
@liuXinGangChina liuXinGangChina force-pushed the autoware_motion_velocity_obstacle_stop_module_porting branch 3 times, most recently from 0b57533 to a91de05 Compare March 26, 2025 03:35
@liuXinGangChina liuXinGangChina force-pushed the autoware_motion_velocity_obstacle_stop_module_porting branch from 73c5a5b to 69e68d7 Compare March 26, 2025 07:12
@liuXinGangChina liuXinGangChina force-pushed the autoware_motion_velocity_obstacle_stop_module_porting branch 2 times, most recently from c1acad5 to fee3817 Compare March 26, 2025 08:16
@liuXinGangChina liuXinGangChina marked this pull request as ready for review March 26, 2025 08:55
@liuXinGangChina liuXinGangChina force-pushed the autoware_motion_velocity_obstacle_stop_module_porting branch from fee3817 to ebdd348 Compare March 27, 2025 05:38
@liuXinGangChina liuXinGangChina force-pushed the autoware_motion_velocity_obstacle_stop_module_porting branch 3 times, most recently from b310c6a to cd63e8a Compare March 27, 2025 07:36
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 671 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (4cb18f5) to head (0146277).
Report is 121 commits behind head on main.

Files with missing lines Patch % Lines
..._obstacle_stop_module/src/obstacle_stop_module.cpp 0.00% 585 Missing ⚠️
...n_velocity_obstacle_stop_module/src/parameters.hpp 0.00% 68 Missing ⚠️
...motion_velocity_obstacle_stop_module/src/types.hpp 0.00% 9 Missing ⚠️
...tacle_stop_module/src/stop_planning_debug_info.hpp 0.00% 8 Missing ⚠️
..._obstacle_stop_module/src/obstacle_stop_module.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #310       +/-   ##
==========================================
- Coverage   78.75%   0.00%   -78.76%     
==========================================
  Files          11     103       +92     
  Lines         193    7464     +7271     
  Branches       73    1320     +1247     
==========================================
- Hits          152       0      -152     
- Misses         11    7464     +7453     
+ Partials       30       0       -30     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liuXinGangChina
Copy link
Contributor Author

liuXinGangChina commented Mar 27, 2025

Hi Kondo san @youtalk

please help review
This pr and its paired pr autowarefoundation/autoware_universe#10348

they both pass ci checks now

Thanks

心刚

@youtalk youtalk self-requested a review March 27, 2025 07:51
@liuXinGangChina liuXinGangChina force-pushed the autoware_motion_velocity_obstacle_stop_module_porting branch from da790cf to edac1a7 Compare March 27, 2025 08:02
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit fixed my suggestion. Then LGTM.

@youtalk youtalk moved this from In Progress to Merge Ready in Autoware Core Porting Mar 27, 2025
@liuXinGangChina liuXinGangChina force-pushed the autoware_motion_velocity_obstacle_stop_module_porting branch from 66b2d83 to b1837d6 Compare March 27, 2025 08:18
@liuXinGangChina liuXinGangChina force-pushed the autoware_motion_velocity_obstacle_stop_module_porting branch from d4ba408 to 05eea22 Compare March 27, 2025 08:43
liuXinGangChina and others added 5 commits March 27, 2025 18:10
…_motion_velocity_obstacle_stop_module, autoware_motion_velocity_obstacle_stop_module, port to core repo: v0.0

Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>
…_motion_velocity_obstacle_stop_module, autoware_motion_velocity_obstacle_stop_module, remove metrics msgs publish according to pr-10342 under universe repo: v0.1

Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>
@liuXinGangChina liuXinGangChina force-pushed the autoware_motion_velocity_obstacle_stop_module_porting branch from 05eea22 to 0146277 Compare March 27, 2025 10:10
@mitsudome-r mitsudome-r merged commit 2263533 into main Mar 27, 2025
24 of 26 checks passed
@mitsudome-r mitsudome-r deleted the autoware_motion_velocity_obstacle_stop_module_porting branch March 27, 2025 11:40
@github-project-automation github-project-automation bot moved this from Merge Ready to Done in Autoware Core Porting Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:moving Temporary label to represent packages that are specifically moving from Universe to Core.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants