-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_motion_velocity_obstacle_stop_module): port to core repo #310
feat(autoware_motion_velocity_obstacle_stop_module): port to core repo #310
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
0b57533
to
a91de05
Compare
...otion_velocity_planner/autoware_motion_velocity_obstacle_stop_module/src/metrics_manager.hpp
Outdated
Show resolved
Hide resolved
73c5a5b
to
69e68d7
Compare
c1acad5
to
fee3817
Compare
fee3817
to
ebdd348
Compare
b310c6a
to
cd63e8a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
- Coverage 78.75% 0.00% -78.76%
==========================================
Files 11 103 +92
Lines 193 7464 +7271
Branches 73 1320 +1247
==========================================
- Hits 152 0 -152
- Misses 11 7464 +7453
+ Partials 30 0 -30
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi Kondo san @youtalk please help review they both pass ci checks now Thanks 心刚 |
da790cf
to
edac1a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit fixed my suggestion. Then LGTM.
66b2d83
to
b1837d6
Compare
d4ba408
to
05eea22
Compare
…_motion_velocity_obstacle_stop_module, autoware_motion_velocity_obstacle_stop_module, port to core repo: v0.0 Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>
…_motion_velocity_obstacle_stop_module, autoware_motion_velocity_obstacle_stop_module, remove metrics msgs publish according to pr-10342 under universe repo: v0.1 Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>
05eea22
to
0146277
Compare
Description
porting autoware_motion_velocity_obstacle_stop_module from universe to core
what i have done:
xxx/stop/metrics
use this message output to no nodes within autoware. It is just for autware user to monitor this plugin.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
Must merge after pr -- #230
Must merge with pr under universe repo -- autowarefoundation/autoware_universe#10348
Interface changes
None.
Effects on system behavior
None.