refactor(autoware_lanelet2_utils): rewrite using modern C++ without API breakage #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
youtalk
added
run:build-and-test-differential
youtalk
added
run:build-and-test-differential
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
===========================================
- Coverage 78.75% 32.52% -46.24%
===========================================
Files 11 15 +4
Lines 193 329 +136
Branches 73 62 -11
===========================================
- Hits 152 107 -45
- Misses 11 215 +204
+ Partials 30 7 -23
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
soblin
approved these changes
Mar 31, 2025
|
Considering the impact on downstream, I decided not to add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes refactoring to improve memory efficiency, readability and safety without breaking the API.
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.