feat(autoware_path_generator): use autoware_trajectory for cropping bounds #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhisaki
requested review from
sasakisasaki,
kosuke55,
satoshi-ota,
takayuki5168 and
a team
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yhisaki
force-pushed
the
use-autoware_trajectory-for-cropping-bounds
branch
from
4c57449 to
a94c8e5
Compare
youtalk
reviewed
Mar 31, 2025
|
LGTM |
yhisaki
force-pushed
the
use-autoware_trajectory-for-cropping-bounds
branch
from
eec6a9b to
724ea2e
Compare
yhisaki
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
===========================================
- Coverage 78.75% 19.57% -59.19%
===========================================
Files 11 96 +85
Lines 193 4430 +4237
Branches 73 879 +806
===========================================
+ Hits 152 867 +715
- Misses 11 3461 +3450
- Partials 30 102 +72
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kosuke55
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
LGTM
- Spline interpolation of autoware_trajectory is buggy, so it is neccesary to fix in aother PR
- Linear interpolation is appropriate for path bound, since we want to maintain the lane boundaries. Linear interpolation is not buggy and can be replaced (this PR)
…ounds Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
kosuke55
force-pushed
the
use-autoware_trajectory-for-cropping-bounds
branch
from
724ea2e to
72bbccf
Compare
youtalk
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use autoware_trajectory for cropping bounds in
crop_line_string. These changes simplify the function without changing the behavior.Related links
How was this PR tested?
psim
path_generator.webm
https://evaluation.tier4.jp/evaluation/reports/fe0540ad-4308-55e0-a13d-48919cee6add?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.