chore: include iostream and link yaml-cpp for Jazzy #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timple
requested review from
soblin,
takayuki5168,
yhisaki and
a team
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Timple
requested review from
JianKangEgon,
sasakisasaki,
kyoichi-sugahara,
TakaHoribe and
zulfaqar-azmi-t4
as code owners
Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Timple
force-pushed
the
iostream-for-cout
branch
from
5fe014e to
748bf8a
Compare
|
Sorry, I hijacked my own PR to also fix the linking. Now everything I need compiles fine under Jazzy 😎 |
Timple
changed the title
Timple
changed the title
soblin
approved these changes
Apr 1, 2025
|
I don't have merge access, so someone else may hit that button 🙂 |
xmfcx
added
the
run:build-and-test-differential
xmfcx
approved these changes
Apr 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
===========================================
- Coverage 78.75% 31.09% -47.67%
===========================================
Files 11 178 +167
Lines 193 11101 +10908
Branches 73 4026 +3953
===========================================
+ Hits 152 3452 +3300
- Misses 11 7174 +7163
- Partials 30 475 +445
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is required for newer compilers (Jazzy) but is also more correct for Humble.
Related links
How was this PR tested?
Compilation
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.