-
Notifications
You must be signed in to change notification settings - Fork 71
fix(autoware_path_optimizer): incorrect application of input velocity due to badly mapping output trajectory to input trajectory #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
911a190
to
6b0daa9
Compare
build-and-test-differential fails, but the test runs successfully on my local PC:
|
6b0daa9
to
1cacd96
Compare
Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
1cacd96
to
5506e4a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
===========================================
- Coverage 78.75% 35.89% -42.87%
===========================================
Files 11 179 +168
Lines 193 11224 +11031
Branches 73 3953 +3880
===========================================
+ Hits 152 4029 +3877
- Misses 11 6783 +6772
- Partials 30 412 +382
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
common/autoware_motion_utils/include/autoware/motion_utils/trajectory/trajectory.hpp
Outdated
Show resolved
Hide resolved
…jectory/trajectory.hpp Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
( the PR title should have been like |
Description
Core changes for autowarefoundation/autoware_universe#10403
Adds a yaw-constrained search for the
findFirstNearestIndexWithSoftConstraints
function that prevents mapping poses to trajectory points with large yaw deviations.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.