Skip to content

fix(autoware_path_optimizer): incorrect application of input velocity due to badly mapping output trajectory to input trajectory #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

PanConChicharron
Copy link
Contributor

@PanConChicharron PanConChicharron commented Apr 7, 2025

Description

Core changes for autowarefoundation/autoware_universe#10403

Adds a yaw-constrained search for the findFirstNearestIndexWithSoftConstraints function that prevents mapping poses to trajectory points with large yaw deviations.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Apr 7, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@PanConChicharron PanConChicharron added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 7, 2025
@PanConChicharron PanConChicharron force-pushed the arjun.ram/RT0-35764 branch 2 times, most recently from 911a190 to 6b0daa9 Compare April 9, 2025 09:04
@PanConChicharron
Copy link
Contributor Author

build-and-test-differential fails, but the test runs successfully on my local PC:

colcon test --ctest-args --rerun-failed --output-on-failure --packages-above autoware_motion_utils

Starting >>> autoware_motion_utils
Finished <<< autoware_motion_utils [0.89s]

Summary: 1 package finished [1.75s]

Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.89%. Comparing base (4cb18f5) to head (70a15fd).
Report is 158 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #355       +/-   ##
===========================================
- Coverage   78.75%   35.89%   -42.87%     
===========================================
  Files          11      179      +168     
  Lines         193    11224    +11031     
  Branches       73     3953     +3880     
===========================================
+ Hits          152     4029     +3877     
- Misses         11     6783     +6772     
- Partials       30      412      +382     
Flag Coverage Δ
differential 35.89% <100.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…jectory/trajectory.hpp

Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit 6e051a1 into main Apr 10, 2025
24 of 26 checks passed
@youtalk youtalk deleted the arjun.ram/RT0-35764 branch April 10, 2025 06:03
@kosuke55
Copy link
Contributor

( the PR title should have been like feat(motion_utils): add yaw constraint ... . I thought path_optimizer is in autoware_core )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants