Skip to content

refactor(autoware_lanelet2_utils)!: move everything to namespace experimental #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Apr 11, 2025

Description

Since this package under development and not stable, move symbols to under autoware::experimental

Related links

Parent Issue:

  • Link

How was this PR tested?

Build/Test passes

Notes for reviewers

None.

Interface changes

APIs move to experimental.

Topic changes

Additions and removals

Change type Topic Type Topic Name Message Type Description
Added/Removed Pub/Sub/Srv/Cli /topic_name std_msgs/String Topic description

Modifications

Version Topic Type Topic Name Message Type Description
Old Pub/Sub/Srv/Cli /old_topic_name sensor_msgs/Image Topic description
New Pub/Sub/Srv/Cli /new_topic_name sensor_msgs/Image Topic description

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
Added/Removed param_name double 1.0 Param description

Modifications

Version Parameter Name Type Default Value Description
Old old_param_name double 1.0 Param description
New new_param_name double 1.0 Param description

🔴⬆️ -->

Effects on system behavior

None.

…rimental

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin requested review from kosuke55 and a team as code owners April 11, 2025 05:44
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 11, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.28%. Comparing base (4cb18f5) to head (f261307).
Report is 163 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #372       +/-   ##
===========================================
- Coverage   78.75%   31.28%   -47.47%     
===========================================
  Files          11       15        +4     
  Lines         193      342      +149     
  Branches       73       64        -9     
===========================================
- Hits          152      107       -45     
- Misses         11      228      +217     
+ Partials       30        7       -23     
Flag Coverage Δ
differential 31.28% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason for Approval

I understand this is needed to do refactoring on the autoware_universe side without any side effect on the autoware_core side.

@soblin
Copy link
Contributor Author

soblin commented Apr 14, 2025

@kosuke55 Can you approve this PR ?

@soblin soblin enabled auto-merge (squash) April 14, 2025 03:48
@soblin soblin merged commit 724c770 into autowarefoundation:main Apr 14, 2025
31 of 34 checks passed
@soblin soblin deleted the refactor/move-autoware-lanlet2-util-experimental branch April 14, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants