-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lanelet2_extension)!: remove dependency on autoware_utils #47
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
f610768
to
b3dc7e0
Compare
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
b3dc7e0
to
d770b37
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 16.31% 16.49% +0.17%
==========================================
Files 42 44 +2
Lines 3089 3098 +9
Branches 1397 1399 +2
==========================================
+ Hits 504 511 +7
Misses 2490 2490
- Partials 95 97 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please add unit tests.
@soblin When you tested the build, did you test with full build of Autoware workspace (including core and universe)? |
Description
remove dependency on autoware_utils for simplicity.
In a few months, utility/query/ will be removed from this package and lanelet2_extension will become just a pure "extension" of lanelet2.
How was this PR tested?
build passes
Notes for reviewers
None.
Effects on system behavior
None.