Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lanelet2_extension)!: remove dependency on autoware_utils #47

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

soblin
Copy link
Collaborator

@soblin soblin commented Feb 27, 2025

Description

remove dependency on autoware_utils for simplicity.

In a few months, utility/query/ will be removed from this package and lanelet2_extension will become just a pure "extension" of lanelet2.

How was this PR tested?

build passes

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Feb 27, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin force-pushed the feat/remove-autoware-utils-dep branch from f610768 to b3dc7e0 Compare February 27, 2025 13:46
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/remove-autoware-utils-dep branch from b3dc7e0 to d770b37 Compare February 27, 2025 13:47
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 16.49%. Comparing base (c84775e) to head (ba5c372).

Files with missing lines Patch % Lines
autoware_lanelet2_extension/lib/query.cpp 0.00% 2 Missing ⚠️
...toware_lanelet2_extension/lib/normalize_radian.hpp 75.00% 0 Missing and 1 partial ⚠️
...elet2_extension/test/src/test_normalize_radian.cpp 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   16.31%   16.49%   +0.17%     
==========================================
  Files          42       44       +2     
  Lines        3089     3098       +9     
  Branches     1397     1399       +2     
==========================================
+ Hits          504      511       +7     
  Misses       2490     2490              
- Partials       95       97       +2     
Flag Coverage Δ *Carryforward flag
differential 16.49% <63.63%> (-0.25%) ⬇️
total 16.32% <ø> (+0.01%) ⬆️ Carriedforward from d770b37

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin marked this pull request as ready for review February 27, 2025 13:57
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please add unit tests.

@mitsudome-r
Copy link
Member

@soblin When you tested the build, did you test with full build of Autoware workspace (including core and universe)?
Since it modifies the package dependency, just testing the build with --packages-up-to autoware_lanelet2_extension might not be enough.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants