Skip to content

revert(autoware_launch): "feat(autoware_launch): use mrm handler by default (#1043)" #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jul 1, 2024

This reverts commit d076aa5.

Description

My understanding is that previously there was a process to ignore the emergency state before route setting. However, by switching to the diagnostics graph, a problem arose where the state becomes emergency when scenario_simulator_v2 starts up, causing the simulation to fail.
I propose temporarily pending the switch to the diagnostics graph until this issue is fixed.

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jul 1, 2024
@kyoichi-sugahara kyoichi-sugahara changed the title Revert "feat(autoware_launch): use mrm handler by default (#1043)" revert(autoware_launch): "feat(autoware_launch): use mrm handler by default (#1043)" Jul 1, 2024
@kyoichi-sugahara kyoichi-sugahara deleted the revert/use_mrm_handler_default branch July 2, 2024 15:57
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware_launch that referenced this pull request Apr 16, 2025
…on#1046)

fix(rviz): add prefix

Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant