feat(pid_long): disable overshoot_emergency #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yuki-takagi-66
requested review from
takayuki5168,
rej55,
satoshi-ota,
shmpwk,
kosuke55,
mkquda,
kyoichi-sugahara,
zulfaqar-azmi-t4,
maxime-clem,
soblin and
yhisaki
as code owners
kyoichi-sugahara
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
This PR is a change to turn off a feature in PID that has become redundant, as PR added functionality for the control_validator to publish diagnostics when crossing over stop lines.
go-sakayori
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Mar 17, 2025
Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>
kosuke55
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Mar 18, 2025
Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The behavior when crossing the stop line is handled by the control_validator as a reference. For this reason, similar functions on the pid_long side are disabled as default.
How was this PR tested?
psim
Notes for reviewers
None.
Effects on system behavior
None.