feat(obstacle_avoidance_planner): param changes for additional failure logging and failure mode handling #1905 #1361
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
github-actions
bot
added
the
component:planning
PanConChicharron
force-pushed
the
arjun.ram/RT0-33698_launch
branch
from
2ae6e42 to
a3b0fc8
Compare
Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
PanConChicharron
force-pushed
the
arjun.ram/RT0-33698_launch
branch
from
f02e9ac to
5af30a8
Compare
PanConChicharron
changed the title
PanConChicharron
changed the title
| - path: /autoware/planning/emergency_stop | ||
| type: and | ||
| list: | ||
| - { type: link, link: /planning/path_optimizer_emergency_stop-error } | ||
|
|
There was a problem hiding this comment.
The path name sounds too general, and we don't have to write this block IMO.
| - { type: link, link: /autoware/planning } | ||
| - { type: link, link: /autoware/system } | ||
| - { type: link, link: /autoware/vehicle } |
There was a problem hiding this comment.
If there is no reason, the changes should be minimized by not re-ordering the existing lines.
| - { type: link, link: /autoware/planning/trajectory_validation } # This line references the path defined below for /autoware/planning/trajectory_validation | ||
| - { type: link, link: /autoware/planning/emergency_stop } # This line references the path defined below for /autoware/planning/emergency_stop |
There was a problem hiding this comment.
I don't think the comment is necessary since the path is referred to in this file as well.
Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
PanConChicharron
force-pushed
the
arjun.ram/RT0-33698_launch
branch
from
6a82bd9 to
89a839b
Compare
| @@ -88,3 +89,15 @@ units: | |||
| type: diag | |||
| node: planning_validator | |||
| name: trajectory_validation_velocity_deviation | |||
|
|
|||
| - path: /autoware/planning/emergency_stop | |||
There was a problem hiding this comment.
I added a comment not to use this path in the TIER IV local autoware_launch repository.
| @@ -63,6 +63,7 @@ units: | |||
| list: | |||
| - { type: link, link: /autoware/vehicle } | |||
| - { type: link, link: /autoware/system } | |||
| - { type: link, link: /autoware/planning } | |||
There was a problem hiding this comment.
This PR modifies the diagnostics/ directory.
But it seems that TIER IV internally uses tier4_diagnostics directory, so please update it instead of this directory.
|
This PR is not needed. Changes to be directed to internal tier4 fork. |
|
Closing. |
Description
Param changes for autowarefoundation/autoware_universe#10276
How was this PR tested?
Notes for reviewers
None.
Effects on system behavior
None.