-
Notifications
You must be signed in to change notification settings - Fork 58
feat(autoware_msg_msgs): add scale factor remove altitude #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_msg_msgs): add scale factor remove altitude #121
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
e608048
to
c052dfd
Compare
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only addition of scale_factor
variable so approving the PR.
PR title says remove altitude, but we are just explicitly saying in the comment that we are not using it. The message still remains as is.
@yukkysaito @youtalk Could you please review this pr? We need approval from two people. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backward compatible. LGTM
we need to bump up the version. Please wait tonight. |
Description
add scale factor remove altitude.
https://github.com/orgs/autowarefoundation/discussions/5765
How was this PR tested?
see autowarefoundation/autoware_core#340
Notes for reviewers
None.
Effects on system behavior
None.