Skip to content

feat(autoware_msg_msgs): add scale factor remove altitude #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Mar 28, 2025

Description

add scale factor remove altitude.

https://github.com/orgs/autowarefoundation/discussions/5765

How was this PR tested?

see autowarefoundation/autoware_core#340

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Mar 28, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@YamatoAndo YamatoAndo changed the title Feat/add scale factor remove altitude feat(autoware_msg_msgs): add scale factor remove altitude Mar 28, 2025
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
@YamatoAndo YamatoAndo force-pushed the feat/add_scale_factor_remove_altitude branch from e608048 to c052dfd Compare March 28, 2025 10:16
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
@YamatoAndo YamatoAndo marked this pull request as ready for review March 28, 2025 10:18
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only addition of scale_factor variable so approving the PR.

PR title says remove altitude, but we are just explicitly saying in the comment that we are not using it. The message still remains as is.

@YamatoAndo YamatoAndo requested review from youtalk and yukkysaito April 2, 2025 09:16
@YamatoAndo
Copy link
Contributor Author

@yukkysaito @youtalk Could you please review this pr? We need approval from two people.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backward compatible. LGTM

@youtalk youtalk enabled auto-merge (squash) April 2, 2025 10:36
@youtalk youtalk merged commit 6332ee2 into autowarefoundation:main Apr 2, 2025
12 checks passed
@youtalk
Copy link
Member

youtalk commented Apr 2, 2025

we need to bump up the version. Please wait tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants