Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_map_msgs): migrate autoware_auto_mapping_msgs to autowa… #65

Conversation

cyn-liu
Copy link

@cyn-liu cyn-liu commented May 30, 2023

Description

migrate autoware_auto_mapping_msgs to autoware_map_msgs.

migrate three messages:
HDMapBin.msg
MapPrimitive.msg
HDMapSegment.msg

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

cyn-liu and others added 2 commits May 30, 2023 14:37
@cyn-liu cyn-liu requested a review from xmfcx June 12, 2023 09:28
@cyn-liu cyn-liu closed this Jun 13, 2023
@xmfcx
Copy link
Collaborator

xmfcx commented Jun 13, 2023

Due to my negligence, I did not see the previous PR, I will close this PR.

@cyn-liu It was our fault too, not making these changes obvious. I'm sorry that you've lost time.

I see that the Universe repository is still using the autoware_auto_map_msg, Have you made a PR for modification?

No, we should update the repository to use these new messages. I think you can start working on this task.

For the control messages I have the following issue with 5 related PRs:

Right now, once the adapter node is created, I will merge rest of them.

Adapter node is to not break compatibility with outside simulator environments.

@cyn-liu
Copy link
Author

cyn-liu commented Jun 13, 2023

No, we should update the repository to use these new messages. I think you can start working on this task.

thanks, great job.
I plan to update the Universe repos with new autoware_map_msg.

@cyn-liu cyn-liu deleted the migrate-autoware-auto-mapping-msgs branch June 13, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants