refactor(goal_planner): remove unnecessary member from PreviousPullOverData (#8698)

soblin · web-flow · commit 1e1d2fcb84fd · 2024-09-02T18:53:24.000+09:00
Signed-off-by: Mamoru Sobue &lt;mamoru.sobue@tier4.jp&gt;
diff --git a/planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/include/autoware/behavior_path_goal_planner_module/goal_planner_module.hpp b/planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/include/autoware/behavior_path_goal_planner_module/goal_planner_module.hpp
@@ -108,12 +108,10 @@ struct PreviousPullOverData
 
   void reset()
   {
-    found_path = false;
     safety_status = SafetyStatus{};
     deciding_path_status = DecidingPathStatusWithStamp{};
   }
 
-  bool found_path{false};
   SafetyStatus safety_status{};
   DecidingPathStatusWithStamp deciding_path_status{};
 };
diff --git a/planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/src/goal_planner_module.cpp b/planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/src/goal_planner_module.cpp
@@ -1529,7 +1529,6 @@ void GoalPlannerModule::updatePreviousData()
   // this is used to determine whether to generate a new stop path or keep the current stop path.
   // TODO(Mamoru Sobue): put prev_data_ out of  ThreadSafeData
   auto prev_data = thread_safe_data_.get_prev_data();
-  prev_data.found_path = thread_safe_data_.foundPullOverPath();
 
   prev_data.deciding_path_status = checkDecidingPathStatus(
     planner_data_, occupancy_grid_map_, *parameters_, ego_predicted_path_params_,

Original file line number	Diff line number	Diff line change
`@@ -108,12 +108,10 @@ struct PreviousPullOverData`
`108`	`108`
`109`	`109`	`void reset()`
`110`	`110`	`{`
`111`		`- found_path = false;`
`112`	`111`	`safety_status = SafetyStatus{};`
`113`	`112`	`deciding_path_status = DecidingPathStatusWithStamp{};`
`114`	`113`	`}`
`115`	`114`
`116`		`- bool found_path{false};`
`117`	`115`	`SafetyStatus safety_status{};`
`118`	`116`	`DecidingPathStatusWithStamp deciding_path_status{};`
`119`	`117`	`};`