refactor(probabilistic_occupancy_grid_map, occupancy_grid_map_outlier_filter): add autoware_ prefix to package name (#8183)

* chore: fix package name probabilistic occupancy grid map

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: solve launch error

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* chore: update occupancy_grid_map_outlier_filter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* style(pre-commit): autofix

* refactor: update package name to autoware_probabilistic_occupancy_grid_map on a test

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename folder of occupancy_grid_map_outlier_filter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Taekjin LEE <taekjin.lee@tier4.jp>

Author: 3 people

.github/CODEOWNERS

@@ -128,9 +128,9 @@ perception/autoware_ground_segmentation/** abrahammonrroy@yahoo.com dai.nguyen@t
 perception/autoware_image_projection_based_fusion/** dai.nguyen@tier4.jp koji.minoda@tier4.jp kotaro.uetake@tier4.jp shunsuke.miura@tier4.jp tao.zhong@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
 perception/autoware_lidar_apollo_instance_segmentation/** yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
 perception/autoware_lidar_centerpoint/** kenzo.lobos@tier4.jp koji.minoda@tier4.jp
-perception/occupancy_grid_map_outlier_filter/** abrahammonrroy@yahoo.com yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
-perception/probabilistic_occupancy_grid_map/** mamoru.sobue@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
+perception/autoware_occupancy_grid_map_outlier_filter/** abrahammonrroy@yahoo.com yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
 perception/autoware_radar_tracks_msgs_converter/** satoshi.tanaka@tier4.jp shunsuke.miura@tier4.jp taekjin.lee@tier4.jp yoshi.ri@tier4.jp
+perception/autoware_probabilistic_occupancy_grid_map/** mamoru.sobue@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
 perception/autoware_raindrop_cluster_filter/** dai.nguyen@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
 perception/autoware_shape_estimation/** yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
 perception/autoware_simple_object_merger/** satoshi.tanaka@tier4.jp shunsuke.miura@tier4.jp yoshi.ri@tier4.jp

launch/tier4_perception_launch/launch/obstacle_segmentation/ground_segmentation/ground_segmentation.launch.py

@@ -331,7 +331,7 @@ def create_time_series_outlier_filter_components(input_topic, output_topic):
         components = []
         components.append(
             ComposableNode(
-                package="occupancy_grid_map_outlier_filter",
+                package="autoware_occupancy_grid_map_outlier_filter",
                 plugin="autoware::occupancy_grid_map_outlier_filter::OccupancyGridMapOutlierFilterComponent",
                 name="occupancy_grid_based_outlier_filter",
                 remappings=[

launch/tier4_perception_launch/launch/occupancy_grid_map/probabilistic_occupancy_grid_map.launch.xml

@@ -16,7 +16,7 @@
 
   <!--pointcloud based method-->
   <group if="$(eval &quot;'$(var occupancy_grid_map_method)'=='pointcloud_based_occupancy_grid_map'&quot;)">
-    <include file="$(find-pkg-share probabilistic_occupancy_grid_map)/launch/pointcloud_based_occupancy_grid_map.launch.py">
+    <include file="$(find-pkg-share autoware_probabilistic_occupancy_grid_map)/launch/pointcloud_based_occupancy_grid_map.launch.py">
       <arg name="input/obstacle_pointcloud" value="$(var input/obstacle_pointcloud)"/>
       <arg name="input/raw_pointcloud" value="$(var input/raw_pointcloud)"/>
       <arg name="output" value="$(var output)"/>
@@ -32,7 +32,7 @@
 
   <!--laserscan based method-->
   <group if="$(eval &quot;'$(var occupancy_grid_map_method)'=='laserscan_based_occupancy_grid_map'&quot;)">
-    <include file="$(find-pkg-share probabilistic_occupancy_grid_map)/launch/laserscan_based_occupancy_grid_map.launch.py">
+    <include file="$(find-pkg-share autoware_probabilistic_occupancy_grid_map)/launch/laserscan_based_occupancy_grid_map.launch.py">
       <arg name="input/obstacle_pointcloud" value="$(var input/obstacle_pointcloud)"/>
       <arg name="input/raw_pointcloud" value="$(var input/raw_pointcloud)"/>
       <arg name="output" value="$(var output)"/>
@@ -50,7 +50,7 @@
 
   <!--multi lidar pointclouds based method-->
   <group if="$(eval &quot;'$(var occupancy_grid_map_method)'=='multi_lidar_pointcloud_based_occupancy_grid_map'&quot;)">
-    <include file="$(find-pkg-share probabilistic_occupancy_grid_map)/launch/multi_lidar_pointcloud_based_occupancy_grid_map.launch.py">
+    <include file="$(find-pkg-share autoware_probabilistic_occupancy_grid_map)/launch/multi_lidar_pointcloud_based_occupancy_grid_map.launch.py">
       <arg name="input/obstacle_pointcloud" value="$(var input/obstacle_pointcloud)"/>
       <arg name="output" value="/perception/occupancy_grid_map/map"/>
       <arg name="use_intra_process" value="true"/>

launch/tier4_perception_launch/package.xml

@@ -29,7 +29,9 @@
   <exec_depend>autoware_object_merger</exec_depend>
   <exec_depend>autoware_object_range_splitter</exec_depend>
   <exec_depend>autoware_object_velocity_splitter</exec_depend>
+  <exec_depend>autoware_occupancy_grid_map_outlier_filter</exec_depend>
   <exec_depend>autoware_pointcloud_preprocessor</exec_depend>
+  <exec_depend>autoware_probabilistic_occupancy_grid_map</exec_depend>
   <exec_depend>autoware_radar_crossing_objects_noise_filter</exec_depend>
   <exec_depend>autoware_radar_fusion_to_detected_object</exec_depend>
   <exec_depend>autoware_radar_object_clustering</exec_depend>
@@ -38,9 +40,7 @@
   <exec_depend>autoware_shape_estimation</exec_depend>
   <exec_depend>autoware_tracking_object_merger</exec_depend>
   <exec_depend>image_transport_decompressor</exec_depend>
-  <exec_depend>occupancy_grid_map_outlier_filter</exec_depend>
   <exec_depend>pointcloud_to_laserscan</exec_depend>
-  <exec_depend>probabilistic_occupancy_grid_map</exec_depend>
   <exec_depend>topic_tools</exec_depend>
   <exec_depend>traffic_light_arbiter</exec_depend>
 

perception/autoware_detected_object_validation/launch/occupancy_grid_based_validator.launch.xml

@@ -5,11 +5,11 @@
 
   <arg name="input/laserscan" default="/perception/occupancy_grid_map/virtual_scan/laserscan"/>
   <arg name="input/occupancy_grid_map" default="/perception/object_recognition/detection/validation/occupancy_grid_based/single_frame_occupancy_grid_map"/>
-  <arg name="occupancy_grid_map_param_path" default="$(find-pkg-share probabilistic_occupancy_grid_map)/config/laserscan_based_occupancy_grid_map.param.yaml"/>
-  <arg name="occupancy_grid_map_updater_param_path" default="$(find-pkg-share probabilistic_occupancy_grid_map)/config/binary_bayes_filter_updater.param.yaml"/>
+  <arg name="occupancy_grid_map_param_path" default="$(find-pkg-share autoware_probabilistic_occupancy_grid_map)/config/laserscan_based_occupancy_grid_map.param.yaml"/>
+  <arg name="occupancy_grid_map_updater_param_path" default="$(find-pkg-share autoware_probabilistic_occupancy_grid_map)/config/binary_bayes_filter_updater.param.yaml"/>
   <arg name="occupancy_grid_based_validator_param_path" default="$(find-pkg-share autoware_detected_object_validation)/config/occupancy_grid_based_validator_param_path.param.yaml"/>
 
-  <node pkg="probabilistic_occupancy_grid_map" exec="laserscan_based_occupancy_grid_map_node" name="single_frame_laserscan_occupancy_grid_map" output="screen">
+  <node pkg="autoware_probabilistic_occupancy_grid_map" exec="laserscan_based_occupancy_grid_map_node" name="single_frame_laserscan_occupancy_grid_map" output="screen">
     <remap from="~/input/laserscan" to="$(var input/laserscan)"/>
     <remap from="~/output/occupancy_grid_map" to="$(var input/occupancy_grid_map)"/>
     <param name="input_obstacle_pointcloud" value="false"/>

perception/occupancy_grid_map_outlier_filter/CMakeLists.txt renamed to perception/autoware_occupancy_grid_map_outlier_filter/CMakeLists.txt

@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.14)
-project(occupancy_grid_map_outlier_filter)
+project(autoware_occupancy_grid_map_outlier_filter)
 
 find_package(autoware_cmake REQUIRED)
 autoware_package()
@@ -41,6 +41,6 @@ endif()
 # -- Occupancy Grid Map Outlier Filter --
 rclcpp_components_register_node(${PROJECT_NAME}
   PLUGIN "autoware::occupancy_grid_map_outlier_filter::OccupancyGridMapOutlierFilterComponent"
-  EXECUTABLE occupancy_grid_map_outlier_filter_node)
+  EXECUTABLE ${PROJECT_NAME}_node)
 
 ament_auto_package(INSTALL_TO_SHARE)

perception/occupancy_grid_map_outlier_filter/README.md renamed to perception/autoware_occupancy_grid_map_outlier_filter/README.md

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="3">
-  <name>occupancy_grid_map_outlier_filter</name>
+  <name>autoware_occupancy_grid_map_outlier_filter</name>
   <version>0.1.0</version>
   <description>The ROS 2 occupancy_grid_map_outlier_filter package</description>
   <maintainer email="abrahammonrroy@yahoo.com">amc-nu</maintainer>

perception/occupancy_grid_map_outlier_filter/image/occupancy_grid_map_outlier_filter.drawio.svg renamed to perception/autoware_occupancy_grid_map_outlier_filter/image/occupancy_grid_map_outlier_filter.drawio.svg

@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.14)
-project(probabilistic_occupancy_grid_map)
+project(autoware_probabilistic_occupancy_grid_map)
 
 find_package(autoware_cmake REQUIRED)
 autoware_package()

perception/occupancy_grid_map_outlier_filter/package.xml renamed to perception/autoware_occupancy_grid_map_outlier_filter/package.xml

@@ -3,7 +3,7 @@
   <group>
     <push-ros-namespace namespace="/perception/occupancy_grid_map/"/>
     <node name="grid_map_visualization" pkg="grid_map_visualization" exec="grid_map_visualization">
-      <param from="$(find-pkg-share probabilistic_occupancy_grid_map)/config/grid_map_param.yaml"/>
+      <param from="$(find-pkg-share autoware_probabilistic_occupancy_grid_map)/config/grid_map_param.yaml"/>
     </node>
   </group>
 </launch>

perception/occupancy_grid_map_outlier_filter/src/occupancy_grid_map_outlier_filter_node.cpp renamed to perception/autoware_occupancy_grid_map_outlier_filter/src/occupancy_grid_map_outlier_filter_node.cpp

@@ -84,7 +84,7 @@ def launch_setup(context, *args, **kwargs):
             extra_arguments=[{"use_intra_process_comms": LaunchConfiguration("use_intra_process")}],
         ),
         ComposableNode(
-            package="probabilistic_occupancy_grid_map",
+            package="autoware_probabilistic_occupancy_grid_map",
             plugin="autoware::occupancy_grid_map::LaserscanBasedOccupancyGridMapNode",
             name="occupancy_grid_map_node",
             remappings=[
@@ -162,13 +162,13 @@ def add_launch_arg(name: str, default_value=None):
             add_launch_arg("output/stixel", "virtual_scan/stixel"),
             add_launch_arg(
                 "param_file",
-                get_package_share_directory("probabilistic_occupancy_grid_map")
+                get_package_share_directory("autoware_probabilistic_occupancy_grid_map")
                 + "/config/laserscan_based_occupancy_grid_map.param.yaml",
             ),
             add_launch_arg("updater_type", "binary_bayes_filter"),
             add_launch_arg(
                 "updater_param_file",
-                get_package_share_directory("probabilistic_occupancy_grid_map")
+                get_package_share_directory("autoware_probabilistic_occupancy_grid_map")
                 + "/config/updater.param.yaml",
             ),
             add_launch_arg("input_obstacle_pointcloud", "false"),

perception/occupancy_grid_map_outlier_filter/src/occupancy_grid_map_outlier_filter_node.hpp renamed to perception/autoware_occupancy_grid_map_outlier_filter/src/occupancy_grid_map_outlier_filter_node.hpp

@@ -195,7 +195,7 @@ def launch_setup(context, *args, **kwargs):
 
         # generate composable node
         node = ComposableNode(
-            package="probabilistic_occupancy_grid_map",
+            package="autoware_probabilistic_occupancy_grid_map",
             plugin="autoware::occupancy_grid_map::PointcloudBasedOccupancyGridMapNode",
             name="occupancy_grid_map_node",
             namespace=frame_name,
@@ -218,7 +218,7 @@ def launch_setup(context, *args, **kwargs):
     # 2. launch occupancy grid map fusion node
     gridmap_fusion_node = [
         ComposableNode(
-            package="probabilistic_occupancy_grid_map",
+            package="autoware_probabilistic_occupancy_grid_map",
             plugin="synchronized_grid_map_fusion::GridMapFusionNode",
             name="occupancy_grid_map_fusion_node",
             remappings=[
@@ -275,13 +275,13 @@ def add_launch_arg(name: str, default_value=None):
             add_launch_arg("output", "occupancy_grid"),
             add_launch_arg(
                 "multi_lidar_fusion_config_file",
-                get_package_share_directory("probabilistic_occupancy_grid_map")
+                get_package_share_directory("autoware_probabilistic_occupancy_grid_map")
                 + "/config/multi_lidar_pointcloud_based_occupancy_grid_map.param.yaml",
             ),
             add_launch_arg("updater_type", "binary_bayes_filter"),
             add_launch_arg(
                 "updater_param_file",
-                get_package_share_directory("probabilistic_occupancy_grid_map")
+                get_package_share_directory("autoware_probabilistic_occupancy_grid_map")
                 + "/config/binary_bayes_filter_updater.param.yaml",
             ),
             set_container_executable,

perception/probabilistic_occupancy_grid_map/CMakeLists.txt renamed to perception/autoware_probabilistic_occupancy_grid_map/CMakeLists.txt

@@ -95,7 +95,7 @@ def launch_setup(context, *args, **kwargs):
 
     composable_nodes.append(
         ComposableNode(
-            package="probabilistic_occupancy_grid_map",
+            package="autoware_probabilistic_occupancy_grid_map",
             plugin="autoware::occupancy_grid_map::PointcloudBasedOccupancyGridMapNode",
             name="occupancy_grid_map_node",
             remappings=[
@@ -173,13 +173,13 @@ def add_launch_arg(name: str, default_value=None):
             add_launch_arg("output", "occupancy_grid"),
             add_launch_arg(
                 "param_file",
-                get_package_share_directory("probabilistic_occupancy_grid_map")
+                get_package_share_directory("autoware_probabilistic_occupancy_grid_map")
                 + "/config/pointcloud_based_occupancy_grid_map.param.yaml",
             ),
             add_launch_arg("updater_type", "binary_bayes_filter"),
             add_launch_arg(
                 "updater_param_file",
-                get_package_share_directory("probabilistic_occupancy_grid_map")
+                get_package_share_directory("autoware_probabilistic_occupancy_grid_map")
                 + "/config/binary_bayes_filter_updater.param.yaml",
             ),
             set_container_executable,

perception/probabilistic_occupancy_grid_map/README.md renamed to perception/autoware_probabilistic_occupancy_grid_map/README.md

@@ -1,9 +1,9 @@
 <?xml version="1.0"?>
 <launch>
   <arg name="output_topic" default="~/output/occupancy_grid_map"/>
-  <arg name="fusion_node_param_path" default="$(find-pkg-share probabilistic_occupancy_grid_map)/config/synchronized_grid_map_fusion_node.param.yaml"/>
+  <arg name="fusion_node_param_path" default="$(find-pkg-share autoware_probabilistic_occupancy_grid_map)/config/synchronized_grid_map_fusion_node.param.yaml"/>
 
-  <node name="synchronized_grid_map_fusion_node" exec="synchronized_grid_map_fusion_node" pkg="probabilistic_occupancy_grid_map" output="screen">
+  <node name="synchronized_grid_map_fusion_node" exec="synchronized_grid_map_fusion_node" pkg="autoware_probabilistic_occupancy_grid_map" output="screen">
     <remap from="~/output/occupancy_grid_map" to="$(var output_topic)"/>
     <param from="$(var fusion_node_param_path)"/>
   </node>

perception/probabilistic_occupancy_grid_map/config/binary_bayes_filter_updater.param.yaml renamed to perception/autoware_probabilistic_occupancy_grid_map/config/binary_bayes_filter_updater.param.yaml

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="3">
-  <name>probabilistic_occupancy_grid_map</name>
+  <name>autoware_probabilistic_occupancy_grid_map</name>
   <version>0.1.0</version>
   <description>generate probabilistic occupancy grid map</description>
   <maintainer email="yukihiro.saito@tier4.jp">Yukihiro Saito</maintainer>