Skip to content

Commit 80587bc

Browse files
committed
fix(diagnostic_graph_aggregator): fix uselessOverride warning
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
1 parent 3e07609 commit 80587bc

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

Diff for: system/diagnostic_graph_aggregator/src/common/graph/units.cpp

-10
Original file line numberDiff line numberDiff line change
@@ -151,16 +151,6 @@ void MaxUnit::update_status()
151151
status_.level = std::min(level, DiagnosticStatus::ERROR);
152152
}
153153

154-
void ShortCircuitMaxUnit::update_status()
155-
{
156-
// TODO(Takagi, Isamu): update link flags.
157-
DiagnosticLevel level = DiagnosticStatus::OK;
158-
for (const auto & link : links_) {
159-
level = std::max(level, link->child()->level());
160-
}
161-
status_.level = std::min(level, DiagnosticStatus::ERROR);
162-
}
163-
164154
MinUnit::MinUnit(const UnitLoader & unit) : NodeUnit(unit)
165155
{
166156
links_ = unit.children();

Diff for: system/diagnostic_graph_aggregator/src/common/graph/units.hpp

-3
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,6 @@ class ShortCircuitMaxUnit : public MaxUnit
137137
public:
138138
using MaxUnit::MaxUnit;
139139
std::string type() const override { return unit_name::short_circuit_max; }
140-
141-
private:
142-
void update_status() override;
143140
};
144141

145142
class MinUnit : public NodeUnit

0 commit comments

Comments
 (0)