-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_lidar_bevfusion): implementation of bevusion using tensorrt #10024
base: main
Are you sure you want to change the base?
Conversation
…ion_ros2 Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
|
@xmfcx |
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
As TensorRT was upgraded and spconv was added (autowarefoundation/autoware#5794), I will be opening this PR 🎉 |
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
…into feat/bevfusion
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
…into feat/bevfusion
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10024 +/- ##
==========================================
+ Coverage 26.24% 26.26% +0.02%
==========================================
Files 1378 1378
Lines 107445 107468 +23
Branches 41428 41433 +5
==========================================
+ Hits 28194 28222 +28
+ Misses 76433 76425 -8
- Partials 2818 2821 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@amadeuszsz |
@knzo25 thank you for this great work. If I may ask a quick question. In terms of bevfusion inference through trt, what's the main difference between the version under your development:https://github.com/knzo25/autoware.universe/tree/feat/bevfusion/perception/autoware_lidar_bevfusion |
The main difference with With respect to the original implementation, those questions may be better suited for our ml stack rather than the inference node here. But in a few words, the lidar model more or less remains the same, although we have evaluated bigger models for offline purposes (we have also tweaked some minor things that have increased performance). The camera-lidar model was too focused on nuscenes, so there have been a few other developments as well, but nothing so big. |
@knzo25 thanks for active response knzo. So in short, just like the centerpoint inference node already published through autoware universe, the actualy inference cpp and cu code has been modifed and optimised by you and rest of community ? The nvda one may be suitable for exact original model trained on nuscense dataset but certainly not as efficient as for autoware retrained centerpoint or bevfusion should we say? And when would you expect this bevfusion trt inference + ros2 node to be available open source ? |
@freejumperd As for when this will be available open source? In a way, it already is, since you can use this branch under the Apache license. As for when will this be merged, it is really up to the reviewers. If you want to play a part in that, we really would appreciate it! |
@knzo25 thanks for explaining. I am certainly interested and plan to go through the recently published AWML pipeline and then running inference test to check FPS etc. |
@freejumperd |
@knzo25 thanks again, what's been discussed are really helpful! Let me leverage with AWML pipeline first to revise our own data pipeline. Will come back to you later for any potential collaboration on the perception topics. |
@freejumperd |
@knzo25 amazing! You guys really have done some great work for promoting such advanced early fusion architecture for open source community. Really looking forward to learn more out of it. And also looking for any coming good work leveraging with VLMs 😉 |
Description
This PR introduces BEVFusion to autoware using TensorRT.
I would like to ask reviewers to let the "integration" into the pipeline/launchers to a posterior PR 🙏
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
The onnx files can be found here: TIER IV INTERNAL LINK. The models will be uploaded to a public link as the last part of the review (we are currently facing issues about the best way to distribute them without affecting CI/CD and image sizes...)
Since this package introduces early fusion, it can not directly be integrated into autoware (the lidar-only model can). Such integration should be relegated to the next PR to avoid increasing unnecessarily the number of stakeholders on this PR.
To test the PR, I recommend using the taxi project (will omit the launch command), and launch bevfusion separatedly.
For now, the models must be placed in the
config
folder, and to change the modality (default is camera-lidar), the `yaml' file can be modified. This is the yaml file parameters needed for the lidar-only model.Interface changes
None.
Effects on system behavior
None.