fix(diagnostic_graph_aggregator): fix uselessOverride warning

[veqcc]

Description

This is a fix based on cppcheck uselessOverride warning

system/diagnostic_graph_aggregator/src/common/graph/units.hpp:142:8: style: The function 'update_status' overrides a function in a base class but is identical to the overridden function [uselessOverride]
  void update_status() override;
       ^
system/diagnostic_graph_aggregator/src/common/graph/units.hpp:132:8: note: Virtual function in base class
  void update_status() override;
       ^
system/diagnostic_graph_aggregator/src/common/graph/units.hpp:142:8: note: Function in derived class
  void update_status() override;
       ^

Though the program is totally the same, I found a TODO comment // TODO(Takagi, Isamu): update link flags..
If you do not want to delete it, please come up with some workarounds!

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.67%. Comparing base (c2f9579) to head (fe8f80c).
Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #7768       +/-   ##
===========================================
+ Coverage   28.40%   64.67%   +36.27%     
===========================================
  Files        1584       18     -1566     
  Lines      115463      620   -114843     
  Branches    49233      285    -48948     
===========================================
- Hits        32796      401    -32395     
+ Misses      73662      156    -73506     
+ Partials     9005       63     -8942     

Flag	Coverage Δ
differential	64.67% <ø> (?)
total	?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[isamu-takagi]

@veqcc As noted in the TODO comments, this will be processed differently in the future. So this is intentional, can I disable the check on a code block?

[veqcc]

@isamu-takagi
Thank you for your quick response.

As noted in the TODO comments, this will be processed differently in the future. So this is intentional, can I disable the check on a code block?

OK, then I will restore the code block and use inline cppcheck suppression (I'll do it tomorrow).
Btw, do you know when the TODO comment will be resolved?

[veqcc]

@isamu-takagi
Could you wait till the cppcheck-differential workflow is updated sp that PRs which changes only .hpp or .cpp can avoid false positive or false negative results?

Related Link (TIER IV internal): https://star4.slack.com/archives/C070FQMREVB/p1719877783942809

Added:
completed two changes on cppcheck-diffferantial and ready for merge

• chore(ci): run cppcheck-differential on modified packages #7777 (review)
• chore(ci): add inline suppressions to cppcheck #7775

[veqcc]

@isamu-takagi
Now it's ready for being merged!

[isamu-takagi]

Btw, do you know when the TODO comment will be resolved?

It's not decided yet. I'll update this if I need more detailed diagnostics after using graph.

[isamu-takagi]

Thank you. LGTM