Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run_out): distance calculation to be minimum distance #9194

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielsanchezaran
Copy link
Contributor

Description

This PR fixes a problem with the run out findLongitudinalNearestPoint method. This function should find the point witth the smallest distance, but the negative sign of some of the arc length calculations can break the function. This PR fixes it.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran marked this pull request as ready for review October 30, 2024 06:49
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 30, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@danielsanchezaran danielsanchezaran added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Oct 30, 2024
@danielsanchezaran danielsanchezaran marked this pull request as draft October 30, 2024 08:11
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.64%. Comparing base (ef2777c) to head (c7b5514).
Report is 511 commits behind head on main.

Files with missing lines Patch % Lines
...ehavior_velocity_run_out_module/src/path_utils.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9194      +/-   ##
==========================================
- Coverage   28.65%   28.64%   -0.02%     
==========================================
  Files        1314     1319       +5     
  Lines      101673   101724      +51     
  Branches    39483    39485       +2     
==========================================
+ Hits        29135    29136       +1     
- Misses      69735    69785      +50     
  Partials     2803     2803              
Flag Coverage Δ *Carryforward flag
differential 17.53% <0.00%> (?)
total 28.65% <ø> (+<0.01%) ⬆️ Carriedforward from ef2777c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

stale bot commented Dec 29, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant