fix(simple_planning_simulator): fix bugprone-branch-clone

[kobayu858]

Description

This is a fix based on clang-tidy bugprone-branch-clone error.
The second error was suppressed due to the complexity of the condition.
Conditions can be summarized if necessary.

/home/emb4/autoware/autoware/src/universe/autoware.universe/simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp:588:49: error: repeated branch in conditional chain [bugprone-branch-clone,-warnings-as-errors]
      if constexpr (std::is_same_v<T, Control>) {
                                                ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp:590:8: note: end of the original
      } else if constexpr (std::is_same_v<T, ActuationCommandStamped>) {
       ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp:590:72: note: clone 1 starts here
      } else if constexpr (std::is_same_v<T, ActuationCommandStamped>) {
                                                                       ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp:643:63: error: repeated branch in conditional chain [bugprone-branch-clone,-warnings-as-errors]
    vehicle_model_type_ == VehicleModelType::DELAY_STEER_ACC) {
                                                              ^

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.74%. Comparing base (a32cae1) to head (ee1a443).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9725      +/-   ##
==========================================
- Coverage   28.77%   28.74%   -0.03%     
==========================================
  Files        1457     1458       +1     
  Lines      109221   109246      +25     
  Branches    42566    42566              
==========================================
- Hits        31428    31403      -25     
- Misses      74714    74766      +52     
+ Partials     3079     3077       -2     

Flag	Coverage Δ		*Carryforward flag
differential	27.27% <ø> (?)
total	28.74% <ø> (-0.03%)	⬇️	Carriedforward from 33b9913

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kobayu858]

@soblin @maxime-clem @TakaHoribe @xtk8532704 @tkimura4 @zulfaqar-azmi-t4
Please confirm the PR. Thank you very much.