Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dummy_infrastructure): fix bugprone-reserved-identifier #9727

Closed
wants to merge 1 commit into from

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy bugprone-reserved-identifier error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/system/dummy_infrastructure/src/dummy_infrastructure_node/dummy_infrastructure_node.cpp:27:26: error: declaration uses identifier '_1', which is reserved in the global namespace; cannot be fixed automatically [bugprone-reserved-identifier,-warnings-as-errors]
using std::placeholders::_1;
                         ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Dec 23, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 23, 2024
@kobayu858 kobayu858 requested a review from veqcc December 23, 2024 08:03
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.74%. Comparing base (e5243e4) to head (a0ffd7c).
Report is 143 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9727      +/-   ##
==========================================
- Coverage   29.74%   29.74%   -0.01%     
==========================================
  Files        1443     1443              
  Lines      108681   108675       -6     
  Branches    42663    42661       -2     
==========================================
- Hits        32330    32328       -2     
+ Misses      73172    73168       -4     
  Partials     3179     3179              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 29.74% <ø> (-0.01%) ⬇️ Carriedforward from e5243e4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858
Copy link
Contributor Author

@mitsudome-r
Please confirm the PR. Thank you very much.

@kobayu858
Copy link
Contributor Author

@mitsudome-r
Please confirm the PR. Thank you very much.

@veqcc
Copy link
Contributor

veqcc commented Jan 14, 2025

@mitsudome-r
Hi

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r
Copy link
Member

mitsudome-r commented Jan 15, 2025

@kobayu858 Could you sync with the latest main branch? There were updates in CI and needs the sync to pass the required CI.

@mitsudome-r
Copy link
Member

I have created a new PR with rebased branch #9919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants