Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointpainting_fusion): enable cloud display on image #9813

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Dec 27, 2024

Description

The PointPainting fusion node disables plotting the point cloud on the image because it uses push_back within an OpenMP parallel loop.

#if 0
// Parallelizing loop don't support push_back
if (debugger_) {
debug_image_points.push_back(projected_point);
}
#endif

This PR introduces a method to store the projected points in local vectors and merge them after the for-loop. These updates make it easier for developers and users to debug.

Before:
Screenshot from 2024-12-27 15-33-27

After
Screenshot from 2024-12-27 13-57-35

Related links

Parent Issue:

  • Link

How was this PR tested?

Test with taxi rosbag.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@vividf vividf self-assigned this Dec 27, 2024
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 27, 2024
@vividf vividf added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Dec 27, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@vividf vividf added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.77%. Comparing base (f211728) to head (333e73d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ion_based_fusion/src/pointpainting_fusion/node.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9813      +/-   ##
==========================================
- Coverage   28.78%   28.77%   -0.02%     
==========================================
  Files        1456     1457       +1     
  Lines      109129   109119      -10     
  Branches    42519    42502      -17     
==========================================
- Hits        31416    31395      -21     
- Misses      74636    74648      +12     
+ Partials     3077     3076       -1     
Flag Coverage Δ *Carryforward flag
differential 3.48% <ø> (?)
differential-cuda 2.51% <0.00%> (?)
total 28.77% <ø> (-0.02%) ⬇️ Carriedforward from 7e3a80c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@vividf vividf merged commit c8e0040 into autowarefoundation:main Dec 27, 2024
67 of 82 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 6, 2025
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants