-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pointpainting_fusion): enable cloud display on image #9813
feat(pointpainting_fusion): enable cloud display on image #9813
Conversation
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9813 +/- ##
==========================================
- Coverage 28.78% 28.77% -0.02%
==========================================
Files 1456 1457 +1
Lines 109129 109119 -10
Branches 42519 42502 -17
==========================================
- Hits 31416 31395 -21
- Misses 74636 74648 +12
+ Partials 3077 3076 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
Description
The PointPainting fusion node disables plotting the point cloud on the image because it uses
push_back
within an OpenMP parallel loop.This PR introduces a method to store the projected points in local vectors and merge them after the for-loop. These updates make it easier for developers and users to debug.
Before:

After

Related links
Parent Issue:
How was this PR tested?
Test with taxi rosbag.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.