-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(radar_threshold_filter): add schema file for radar_threshold_filter and upadted the README file #9980
base: main
Are you sure you want to change the base?
feat(radar_threshold_filter): add schema file for radar_threshold_filter and upadted the README file #9980
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please wait until the CI test passed.
Please make the json-schema-check passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated readme please run json again thank you
there is mismatching between schema.json and param.yaml 🔍 Validating: sensing/autoware_radar_threshold_filter/config/radar_threshold_filter.param.yaml 🆚 sensing/autoware_radar_threshold_filter/schema/radar_threshold_filter.schema.json ❌ Failed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9980 +/- ##
=======================================
Coverage 24.68% 24.68%
=======================================
Files 1313 1313
Lines 102699 102694 -5
Branches 38998 38998
=======================================
- Hits 25354 25353 -1
+ Misses 74936 74932 -4
Partials 2409 2409
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
Hi @technolojin san i have fixed it can u try again thank you |
@vish0012 |
|
…ME file Signed-off-by: vish0012 <vishalchhn42@gmail.com>
update README file
Signed-off-by: vish0012 <vishalchhn42@gmail.com>
Signed-off-by: vish0012 <vishalchhn42@gmail.com>
…ew comments Signed-off-by: vish0012 <vishalchhn42@gmail.com>
e0f369b
to
59df106
Compare
…ME file
Description
Related links
Parent Issue:
How was this PR tested?
Successfully build using colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_radar_threshold_filter
Passed ros2 launch launch/radar_threshold_filter.launch.xml
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.