Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radar_threshold_filter): add schema file for radar_threshold_filter and upadted the README file #9980

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

vish0012
Copy link
Contributor

…ME file

Description

  • Implement the ROS Node configuration layout described in Autoware Foundation Discussion #3371 for the (autoware_cluster_merger)
  • Remove duplication of parameter declaration between the source code and the parameter file.
  • Remove the default value from the source code to ensure all parameter values are passed from the parameter files.
  • Use types that match those returned from declare_parameter() to prevent confusion and potential coding errors.
  • Move the default parameter file to a standardized location. Use the JSON Schema for that.
  • Create the schema

Related links

Parent Issue:

  • Link

How was this PR tested?

Successfully build using colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_radar_threshold_filter

Passed ros2 launch launch/radar_threshold_filter.launch.xml

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Jan 20, 2025
Copy link

github-actions bot commented Jan 20, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 20, 2025
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please wait until the CI test passed.

@vish0012 vish0012 changed the title feat: add schema file for radar_threshold_filter and upadted the READ… feat: add schema file for radar_threshold_filter and upadted the README file Jan 21, 2025
@technolojin
Copy link
Contributor

Please make the json-schema-check passed
https://github.com/autowarefoundation/autoware.universe/actions/runs/12860383472/job/35905376882?pr=9980#step:3:89

@MasatoSaeki MasatoSaeki changed the title feat: add schema file for radar_threshold_filter and upadted the README file feat(radar_threshold_filter): add schema file for radar_threshold_filter and upadted the README file Jan 30, 2025
Copy link
Contributor Author

@vish0012 vish0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated readme please run json again thank you

@technolojin technolojin self-assigned this Feb 5, 2025
@technolojin
Copy link
Contributor

there is mismatching between schema.json and param.yaml

🔍 Validating: sensing/autoware_radar_threshold_filter/config/radar_threshold_filter.param.yaml 🆚 sensing/autoware_radar_threshold_filter/schema/radar_threshold_filter.schema.json ❌ Failed

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.68%. Comparing base (fb1901f) to head (59df106).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9980   +/-   ##
=======================================
  Coverage   24.68%   24.68%           
=======================================
  Files        1313     1313           
  Lines      102699   102694    -5     
  Branches    38998    38998           
=======================================
- Hits        25354    25353    -1     
+ Misses      74936    74932    -4     
  Partials     2409     2409           
Flag Coverage Δ *Carryforward flag
differential 82.60% <ø> (?)
differential-cuda 82.60% <ø> (?)
total 24.68% <ø> (+<0.01%) ⬆️ Carriedforward from fb1901f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vish0012
Copy link
Contributor Author

vish0012 commented Feb 6, 2025

there is mismatching between schema.json and param.yaml

🔍 Validating: sensing/autoware_radar_threshold_filter/config/radar_threshold_filter.param.yaml 🆚 sensing/autoware_radar_threshold_filter/schema/radar_threshold_filter.schema.json ❌ Failed

@technolojin thanks you for your comments, i have correct the json file , and check param file could try to run again thanks you.

@technolojin
Copy link
Contributor

Screenshot from 2025-02-12 10-56-15
@vish0012 can you fix it?

@vish0012
Copy link
Contributor Author

Screenshot from 2025-02-12 10-56-15 @vish0012 can you fix it?

@

Screenshot from 2025-02-12 10-56-15 @vish0012 can you fix it?

Hi @technolojin san i have fixed it can u try again thank you

Screenshot from 2025-02-20 12-10-42

@technolojin
Copy link
Contributor

@vish0012
Hi. This PR is forgotten for a long time. It still didn't pass the json-schema-check test, so it cannot be merged.
Can you fix it?

@vish0012
Copy link
Contributor Author

@vish0012 Hi. This PR is forgotten for a long time. It still didn't pass the json-schema-check test, so it cannot be merged. Can you fix it?

@technolojin Hi, thank you, i have correct and it running locally also could you check now , thank you

Screenshot from 2025-03-18 09-41-40

@technolojin technolojin enabled auto-merge (squash) March 18, 2025 04:50
@mitsudome-r mitsudome-r added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Apr 3, 2025
pre-commit-ci bot and others added 2 commits April 4, 2025 00:18
@mitsudome-r mitsudome-r force-pushed the add-schema-radar_threshold_filter branch from e0f369b to 59df106 Compare April 3, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

4 participants