Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_interpolation): porting autoware_interpolation package to autoware.core #10018

Merged

Conversation

NorahXiong
Copy link
Contributor

Description

Related links

Parent Issue:
autoware.core #139

How was this PR tested?

Notes for reviewers

It should be merged with autoware.core #149

Interface changes

None.

Effects on system behavior

None.

@NorahXiong NorahXiong added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 24, 2025
@NorahXiong NorahXiong requested a review from youtalk January 24, 2025 06:56
@NorahXiong NorahXiong self-assigned this Jan 24, 2025
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jan 24, 2025
Copy link

github-actions bot commented Jan 24, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r
Copy link
Member

I'm locally checking build.

@mitsudome-r
Copy link
Member

NOTE: The build-check is passing in the CI, but it should fail.
build-and-test-differntial fails to detect the package that depends on the removed package...

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r
Copy link
Member

The build is testing. This is due to the migration of PathWithLaneId messages.
This has to be merged first.
#10023

…to autoware.core

Signed-off-by: NorahXiong <norah.xiong@autocore.ai>
@mitsudome-r mitsudome-r force-pushed the porting/autoware_interpolation branch from a0663d1 to 51223cc Compare February 12, 2025 11:46
@mitsudome-r
Copy link
Member

All the blockers should be resolved now. I will merge this with the PR in Autoware.Core once all the required checks pass.

@mitsudome-r mitsudome-r merged commit 3274695 into autowarefoundation:main Feb 12, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants