Skip to content

fix(behavior_path_planner, behavior_static_obstacle_avoidance_module): crash during goal changes #10205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 26, 2025

Merge branch 'main' into fix/bpp_empty_path_handling

5eccf87
Select commit
Loading
Failed to load commit list.
Merged

fix(behavior_path_planner, behavior_static_obstacle_avoidance_module): crash during goal changes #10205

Merge branch 'main' into fix/bpp_empty_path_handling
5eccf87
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 26, 2025 in 44s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Prevent hotspot decline (1 hotspot with Complex Method)
Enforce advisory code health rules (1 file with Complex Method)

Gates Passed
2 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Prevent hotspot decline Violations Code Health Impact
scene.cpp 1 rule in this hotspot 5.31 → 5.28 Suppress
Enforce advisory code health rules Violations Code Health Impact
scene.cpp 1 advisory rule 5.31 → 5.28 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method scene.cpp: StaticObstacleAvoidanceModule::fillFundamentalData 🔥

✅ Improving Code Health:

  • Overall Code Complexity planner_manager.cpp

Annotations

Check notice on line 1 in planning/behavior_path_planner/autoware_behavior_path_planner/src/planner_manager.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 5.55 to 5.43, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 223 in planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/src/scene.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

StaticObstacleAvoidanceModule::fillFundamentalData increases in cyclomatic complexity from 9 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.