Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_tracker_object_merger): add diagnostics #10257

Conversation

MasatoSaeki
Copy link
Contributor

@MasatoSaeki MasatoSaeki commented Mar 11, 2025

Description

Add diagnostics to judge following case.

  • main msg(e.g. lidar) is delay
  • main msg(e.g. lidar) continues to be empty
  • sub msg(e.g. radar) is delay

Related links

autowarefoundation/autoware_launch#1357

Parent Issue:

  • Link

How was this PR tested?

https://evaluation.ci.tier4.jp/evaluation/reports/e019a2e3-0b9e-50f6-a238-abb79d8148a0?project_id=prd_jt

I checked certain rosbag w/o radar msg.

Screencast.from.03-12-2025.04.59.34.PM.webm
ros2 launch autoware_launch logging_simulator.launch.xml \
        map_path:=$MAP_PATH \
        pointcloud_map_file:=$MAP_PCD_FILE \
        vehicle_model:=$VEHICLE_MODEL \
        sensor_model:=$SENSOR_MODEL \
        vehicle_id:=$VEHICLE_ID \
        vehicle:=true \
        system:=true \
        map:=true \
        sensing:=true \
        perception:=true \
        localization:=false \
        planning:=false \
        control:=false \
        perception_mode:=camera_lidar_radar_fusion
ros2 bag play hogehoge --clock
ros2 run rqt_runtime_monitor rqt_runtime_monitor

Notes for reviewers

None.

Interface changes

Change type Topic Type Topic Name Message Type Description
Added Pub /diagnostics diagnostic_msgs/msg/DiagnosticArray Topic description

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 11, 2025
Copy link

github-actions bot commented Mar 11, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 12, 2025
MasatoSaeki and others added 10 commits March 12, 2025 17:04
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Co-authored-by: Taekjin LEE <technolojin@gmail.com>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@MasatoSaeki MasatoSaeki force-pushed the feat/add_diag_tracking_object_merger branch from a1eb957 to b63f4f6 Compare March 12, 2025 08:04
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.

Project coverage is 26.17%. Comparing base (429bc34) to head (3d08b54).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ject_merger/src/decorative_tracker_merger_node.cpp 0.00% 52 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10257      +/-   ##
==========================================
+ Coverage   25.64%   26.17%   +0.52%     
==========================================
  Files        1362     1378      +16     
  Lines      104703   107627    +2924     
  Branches    39820    41480    +1660     
==========================================
+ Hits        26856    28174    +1318     
- Misses      75239    76627    +1388     
- Partials     2608     2826     +218     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 26.22% <ø> (+0.57%) ⬆️ Carriedforward from a9f3717

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@MasatoSaeki MasatoSaeki marked this pull request as ready for review March 12, 2025 11:37
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MasatoSaeki MasatoSaeki merged commit 8796045 into autowarefoundation:main Mar 26, 2025
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants