Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use mrm in all operation mode state #10259

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TetsuKawa
Copy link
Contributor

Description

This PR changed that mrm can be used in all operation mode state,

Related links

Private Links:

How was this PR tested?

  1. prepare for autoware
  2. cherry-pick this PR commit to autoware.universe
  3. conlcon build
  4. launch psim
  5. Set Autonomous and execute ros2 param set /dummy_diag_publisher "localization: ekf_localizer".status "Error"
  6. Comfirm that transition to MRM
Screencast.from.2025.03.12.00.32.57.webm
  1. Set to autoware_launch/system/diagnostics/autoware-main.yaml
units:
  - path: /autoware/modes/local
    type: and
    list:
      - { type: link, link: /autoware/vehicle }
      - { type: link, link: /autoware/system }
      - { type: link, link: /autoware/control/local }
      - { type: link, link: /autoware/localization } # <-- add
  1. launch psim
  2. Set Local and execute ros2 param set /dummy_diag_publisher "localization: ekf_localizer".status "Error"
  3. Comfirm that transition to MRM
Screencast.from.2025.03.12.00.40.59.webm

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

When current operation mode state (all) is not available, Autoware executes MRM.

Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
@TetsuKawa TetsuKawa requested a review from s-azumi March 11, 2025 15:47
@TetsuKawa TetsuKawa self-assigned this Mar 11, 2025
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Mar 11, 2025
Copy link

github-actions bot commented Mar 11, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@TetsuKawa TetsuKawa added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 26.23%. Comparing base (fb43521) to head (5ed1fbf).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...e_mrm_handler/src/mrm_handler/mrm_handler_core.cpp 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10259      +/-   ##
==========================================
- Coverage   26.24%   26.23%   -0.01%     
==========================================
  Files        1378     1378              
  Lines      107484   107510      +26     
  Branches    41439    41443       +4     
==========================================
  Hits        28205    28205              
- Misses      76459    76485      +26     
  Partials     2820     2820              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 26.24% <ø> (+<0.01%) ⬆️ Carriedforward from fb43521

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant