Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use mrm in all operation mode state #10259

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Merge branch 'main' into feat/check-current-operation-mode-availability

db8f740
Select commit
Loading
Failed to load commit list.
Open

feat: use mrm in all operation mode state #10259

Merge branch 'main' into feat/check-current-operation-mode-availability
db8f740
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Mar 25, 2025 in 1m 21s

CodeScene PR Check

Quality Gate Passed

Code Health Improved (1 files improve in Code Health)

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

View Improvements
File Code Health Impact Categories Improved
mrm_handler_core.cpp 6.68 → 6.69 Complex Method, Overall Code Complexity

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

✅ Improving Code Health:

  • Overall Code Complexity mrm_handler_core.cpp
  • Complex Method mrm_handler_core.cpp: MrmHandler::updateMrmState

Annotations

Check notice on line 415 in system/autoware_mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method

MrmHandler::updateMrmState decreases in cyclomatic complexity from 15 to 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in system/autoware_mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 5.52 to 5.50, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.