feat(goal_planner): expand outer collision check margin #10294
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Mar 18, 2025 in 1m 0s
CodeScene PR Check
Quality Gate Failed
(1 files improve in Code Health)
Gates Failed
(1 hotspot with Complex Method)
(2 files with Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Prevent hotspot decline | Violations | Code Health Impact | |
|---|---|---|---|
| goal_planner_module.cpp | 1 rule in this hotspot | 3.30 → 3.30 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| manager.cpp | 1 advisory rule | 6.76 → 6.75 | Suppress |
| goal_planner_module.cpp | 1 advisory rule | 3.30 → 3.30 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| util.cpp | 6.67 → 6.83 | Complex Method, Overall Code Complexity |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method manager.cpp: GoalPlannerModuleManager::initGoalPlannerParameters
- Complex Method goal_planner_module.cpp: GoalPlannerModule::selectPullOverPath 🔥
✅ Improving Code Health:
- Overall Code Complexity util.cpp 🔥
- Complex Method util.cpp: checkObjectsCollision 🔥
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
GoalPlannerModule::selectPullOverPath already has high cyclomatic complexity, and now it increases in Lines of Code from 74 to 75. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
GoalPlannerModuleManager::initGoalPlannerParameters already has high cyclomatic complexity, and now it increases in Lines of Code from 350 to 352. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
checkObjectsCollision is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.41 to 4.38, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading