Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_static_obstacle_avoidance_module): blinker bug in static obstacle avoidance #10303

Conversation

yhisaki
Copy link
Contributor

@yhisaki yhisaki commented Mar 19, 2025

Description

  1. The error occurred because unnecessary shift lines were excluded before target_shift_line was selected.
  2. There were duplicate processes excluding small shifts in scene.cpp and turn_signal_decider.cpp.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Mar 19, 2025
Copy link

github-actions bot commented Mar 19, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yhisaki yhisaki force-pushed the fix/blinker_in_static_obstacle_avoidance branch from a01c874 to 24715a9 Compare March 19, 2025 04:38
@github-actions github-actions bot removed the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Mar 19, 2025
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki yhisaki force-pushed the fix/blinker_in_static_obstacle_avoidance branch from 24715a9 to 96d668c Compare March 19, 2025 09:58
@yhisaki yhisaki marked this pull request as ready for review March 21, 2025 02:29
@shmpwk shmpwk added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 21, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 25.91%. Comparing base (004cdfa) to head (96d668c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ath_static_obstacle_avoidance_module/src/scene.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10303      +/-   ##
==========================================
- Coverage   25.92%   25.91%   -0.01%     
==========================================
  Files        1382     1382              
  Lines      106811   106776      -35     
  Branches    40907    40886      -21     
==========================================
- Hits        27691    27676      -15     
+ Misses      76416    76396      -20     
  Partials     2704     2704              
Flag Coverage Δ *Carryforward flag
differential 20.77% <0.00%> (?)
total 25.91% <ø> (-0.01%) ⬇️ Carriedforward from 004cdfa

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhisaki yhisaki merged commit 98ea837 into autowarefoundation:main Mar 21, 2025
47 of 50 checks passed
@yhisaki yhisaki deleted the fix/blinker_in_static_obstacle_avoidance branch March 21, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants