feat(crosswalk_module): consider objects on crosswalk when pedestrian traffic light is red #10332
+30
−12
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Mar 24, 2025 in 37s
CodeScene PR Check
Quality Gate Failed
Gates Failed
(1 file with Bumpy Road Ahead)
(1 file with Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| scene_crosswalk.cpp | 1 critical rule | 5.37 → 5.25 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| scene_crosswalk.cpp | 1 advisory rule | 5.37 → 5.25 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method scene_crosswalk.cpp: CrosswalkModule::updateObjectState
- Bumpy Road Ahead scene_crosswalk.cpp: CrosswalkModule::updateObjectState
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
CrosswalkModule::updateObjectState increases in cyclomatic complexity from 12 to 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
CrosswalkModule::updateObjectState has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading