Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(roi_pointcloud_fusion): add roi scale factor param #10333

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Mar 25, 2025

Description

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 25, 2025
Copy link

github-actions bot commented Mar 25, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 25, 2025
@badai-nguyen badai-nguyen added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Mar 25, 2025
Copy link

Documentation URL: https://autowarefoundation.github.io/autoware_universe/pr-10333/
Modified URLs:

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 25.92%. Comparing base (dbc5923) to head (27ec443).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...age_projection_based_fusion/src/utils/geometry.cpp 0.00% 11 Missing ⚠️
...on_based_fusion/src/roi_pointcloud_fusion/node.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10333      +/-   ##
==========================================
- Coverage   25.92%   25.92%   -0.01%     
==========================================
  Files        1383     1383              
  Lines      106873   106892      +19     
  Branches    40931    40939       +8     
==========================================
  Hits        27708    27708              
- Misses      76459    76478      +19     
  Partials     2706     2706              
Flag Coverage Δ *Carryforward flag
differential 4.17% <0.00%> (?)
differential-cuda 2.84% <0.00%> (?)
total 25.92% <ø> (+<0.01%) ⬆️ Carriedforward from dbc5923

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@badai-nguyen badai-nguyen marked this pull request as ready for review March 25, 2025 23:39
Copy link
Contributor

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit effe347 into autowarefoundation:main Mar 26, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants